Steps to reproduce

  1. Make sure focal point is not installed
  2. Add an image to (lets say) node/3
  3. Enable focal point and setup an image style
  4. Notice that the image attached to node/3 is cropped at the top left of the image

Expected result

In the absence of a focal point value, the default (50,50) should be used

Original report

Hi guys,

Using focal point in an existing live site is not working correctly since the old images are not cropped correctly.

Coordinates that are being used with old images are 0,0.

I have confirmed this issue. The steps to re

CommentFileSizeAuthor
#4 focal_point-fix_existing_images_crop_coordinates-2826418-4-D8.patch784 bytesmpastas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpastas created an issue. See original summary.

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented

Just to double check... these are the steps to reproduce:

  1. Make sure focal point is not installed
  2. Add an image to (lets say) node/3
  3. Enable focal point and setup an image style
  4. Notice that the image attached to node/3 is cropped at the top left of the image

Is this right?

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented
Issue summary: View changes
mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented
FileSize
focal_point-fix_existing_images_crop_coordinates-2826418-4-D8.patch784 bytes

That is right! I noticed the focal point is being calculated with the original image when it is generated right, so maybe the following patch is a fix.

Let me know your comments.

mpastas’s picture

mpastas CreditAttribution: mpastas at Globant commented

Bleen did you have the chance to review it ?

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented
Status: Active » Needs review

here testbot ... here boy

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

Passed tests.

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented
Title: Using focal point in an existing site break old images » When enabling focal point on an existing site, existing images are improperly cropped
Status: Needs review » Reviewed & tested by the community

  • bleen committed 398a1b6 on 8.x-1.x authored by mpastas 
    Issue #2826418 by mpastas: When enabling focal point on an existing site...
bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented

Nice catch. Thanks!!

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.