Rework/update dialog JavaScripts [#2826277]

Problem/Motivation

When using the Bootstrap theme with the entity browser module, I realized, that the modal JavaScripts have some problems:

dialog:beforeclose and dialog:afterclose events are only fired, when the modal is closed via closeDialog() function
Current dialog.js and dialog.ajax.js differ from core's ones

Proposed resolution

Rework dialog JS scripts to be up to date with core's ones
Ensure all events are fired correctly (e.g. by leveraging/binding Bootstraps *.bs.modal events to trigger appropriate events required for Drupal

Remaining tasks

Rework JS files to be up to date with core
Ensure triggering of appropriate events

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#4	bootstrap-fix-core-dialog-events-2826277-4-D8.patch	1.37 KB	stan.ag
#4
#3	bootstrap-fix-core-dialog-events-2826277-3-D8.patch	1.45 KB	stan.ag
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 November 2016 at 08:31

hctom created an issue. See original summary.

Comment #2

stan.ag CreditAttribution: stan.ag as a volunteer commented 20 December 2016 at 07:28

Category:

Task

» Bug report

I confirm that this issue is still actual after 8.x-3.1 release. Changing category to "Bug report" as it actually breaks functionality in some cases ('Entity browser' module being an example, as it relies on 'dialog:beforeclose' event which is not fired if dialog is closed manually).

Comment #3

stan.ag CreditAttribution: stan.ag as a volunteer commented 20 December 2016 at 07:53

File	Size
bootstrap-fix-core-dialog-events-2826277-3-D8.patch	1.45 KB

A quick patch to fix core dialog events.

Comment #4

stan.ag CreditAttribution: stan.ag as a volunteer commented 20 December 2016 at 11:54

File	Size
bootstrap-fix-core-dialog-events-2826277-4-D8.patch	1.37 KB

In previous patch, 'show.bs.modal.drupal' and 'hidden.bs.modal.drupal' events weren't fired. I removed the first event (thus restored original code) and changed dialog.ajax.js in order to fire the last one.