Tests were added a while ago by daniel, but we didn't have automated tests enabled, so it looks like they're broken now.

https://www.drupal.org/pift-ci-job/526221

We should look into to failures and fix the tests.

CommentFileSizeAuthor
#3 2825978-3--fix_tests.patch3.61 KBdrunken monkey
#3 2825978-3--fix_tests--interdiff.txt1.87 KBdrunken monkey
#2 fix_tests-2825978-2.patch2.51 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Active » Needs review
FileSize
fix_tests-2825978-2.patch2.51 KB

The test still doesn't pass but I have no idea how to fix the remaining fail.

1) Drupal\Tests\search_api_autocomplete\Kernel\SearchCrudTest::testCreate
Error: Call to a member function tablePrefix() on null

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
2825978-3--fix_tests--interdiff.txt1.87 KB
2825978-3--fix_tests.patch3.61 KB

Thanks a lot for working on this, looks good!
This should fix the final test, and also provides a bit more doc comments.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Tests are green, woo!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Great, thanks again!
Committed.

The last submitted patch, 2: fix_tests-2825978-2.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 3: 2825978-3--fix_tests.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.