Contextual link to edit queue is not showing with views that have relation and sort on any entityqueue.
Patch will follow

Comments

josebc created an issue. See original summary.

josebc’s picture

Assigned: josebc » Unassigned
Status: Active » Needs review
FileSize
5.29 KB
Mohammed J. Razem’s picture

Title: Contextual links not working on views » Make "Contextual links" work for views using Entityqueue
RajabNatshah’s picture

+1 Testing :)

RajabNatshah’s picture

Status: Needs review » Reviewed & tested by the community
josebc’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
6.18 KB

Added "Settings Tray" support if enabled

RajabNatshah’s picture

+1 Having more testing.

amateescu’s picture

Nice! The patch does make the contextual link appear for views, but the outside-in part doesn't seem to work.. should we remove it from the patch?

josebc’s picture

We have it working using this patch, what theme are you using?

amateescu’s picture

I'm testing on a default D8 install, so using the bartik theme.

josebc’s picture

Thats odd, i just tested on with both 8.2 and 8.3, are there any js errors in console?

RajabNatshah’s picture

I'm in with more testing ...... and automating the test.
I feel that the logic in the code is right,

Scenario: Check if content admins are able to see and click the contextual link to manage entitiyqueues which are attached to views when the Settings Tray outside-in module is not installed
Given that the "Settings Tray" module is not installed
When I go to a page which has a view display in it
And the view display is using an entity queue to sort entities
Then I will be able to see the "entityqueue" contextual link
When I click the "entityqueue" contextual link
And wait for the page to finish loading
Then I should see the list of queued entities
And I can add/reorder and remove entities.

Scenario: Check if content admins are able to see and click the contextual link to manage entityqueues which are attached to views when the Settings Tray outside-in module is installed
Given that the "Settings Tray" module is installed
When I go to a page which has a view display in it
And the view display is using an entity queue to sort entities
Then I will be able to see the "entityqueue" contextual link
When I click the "entityqueue" contextual link
And wait for AJAX to finish
Then I should see the list of queued entities in the "offcanvas" data dialog
And I can add/reorder/reverse and remove entities.

  • amateescu committed b742b40 on 8.x-1.x authored by josebc
    Issue #2825773 by josebc, RajabNatshah, amateescu: Make "Contextual...
amateescu’s picture

Status: Needs review » Fixed
FileSize
5.42 KB
2.18 KB

Spent some more time digging into this and I found out that the reason why I wasn't getting the right behavior with the settings tray is because contextual links are cached in the browser's session storage, and that's not cleared by the regular Drupal cache clearing mechanism.

Anyway, it does work nicely indeed, great work! I cleaned up the patch a little (see attached interdiff) and committed to 8.x-1.x. Thanks!

RajabNatshah’s picture

A preview of Drupal 8 "Outside-In" with Entity Queues.
This is done utilizing Sportsleague distribution and Entityqueue module with the Contextual Links patch.

https://www.youtube.com/watch?v=vr-AqQmLoGs

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.