Missing 'Dash' character in punctuation section.

Comments

krishnarp created an issue. See original summary.

krishnarp’s picture

Added the dash character and created the patch. Kindly add this.

krishnarp’s picture

Assigned: krishnarp » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: pathauto-punctuation-missing-dash-2825644-1.patch, failed testing.

The last submitted patch, 2: pathauto-punctuation-missing-dash-2825644-1.patch, failed testing.

krishnarp’s picture

krishnarp’s picture

Status: Needs work » Needs review
darrenwh’s picture

Status: Needs review » Needs work

Hi, How does this differ from Hyphen (-) on line 657

krishnarp’s picture

Hi Darren,

This is long dash (—) and hyphen is (-). I have got a page not found when my client added node title with this long dash. The client is from a research group. So they will definitely use these from some old reference books .

Thanks
Krishna

darrenwh’s picture

OK,
There is also a hook: function hook_pathauto_punctuation_chars_alter to add additional punctuation that will avoid hacking the module pending approval of your patch.

/*
 * Implements hook_pathauto_punctuation_chars_alter().
 */
function module_pathauto_punctuation_chars_alter(array &$punctuation) {
  // Add the long dash symbol.
  $punctuation['dash'] = array('value' => '—', 'name' => t('Dash'));
} 
krishnarp’s picture

Yeah, Thanks Darren and I know there is a hook. But i thought this should be part of module. That is why i have posted here.

krishnarp’s picture

Status: Needs work » Needs review
darrenwh’s picture

darrenwh’s picture

Hi @krishnarp ,
I think the character is actually a em-dash?
http://www.thepunctuationguide.com/em-dash.html

krishnarp’s picture

@darrenwh Yes you are right.