Resource Caching [#2825594]

Problem/Motivation

In some cases I would like to control the caching of responses.

Proposed resolution

Add in a no cache option to the route when it is created.

Remaining tasks

tests
upgrade path

User interface changes

Added in new options to allow you to set a default no caching and also per resource.

API changes

Data model changes

added no_cache to service_endpoint_resource.schema.yml
added default_no_cache to services.schema.yml

patch to follow

Comment	File	Size	Author
#9	services-resource_caching-2825594-9.patch	7.16 KB	lorenzs
#9	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4 Composer require failure PHP 5.5 & MySQL 5.5, D8.3 Composer require failure PHP 5.5 & MySQL 5.5, D8.3 4 pass PHP 5.5 & MySQL 5.5, D8.3 4 pass
#3	Resource-Caching-2825594.patch	4.98 KB	Gravypower
#3	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.3 CI error
#2	Resource-Caching-2825594.patch	3.3 KB	Gravypower
#2	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.3 CI error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 November 2016 at 01:52

Gravypower created an issue. See original summary.

Comment #2

Gravypower CreditAttribution: Gravypower commented 8 November 2016 at 01:53

File	Size
Resource-Caching-2825594.patch	3.3 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.3 CI error

Comment #3

Gravypower CreditAttribution: Gravypower commented 8 November 2016 at 02:01

File	Size
Resource-Caching-2825594.patch	4.98 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.3 CI error

Forgot to save a few files

Comment #4

Gravypower CreditAttribution: Gravypower commented 8 November 2016 at 02:07

Comment #5

kylebrowning CreditAttribution: kylebrowning as a volunteer and at Acquia commented 6 January 2017 at 17:25

Status:

Active

» Needs review

I like it!

Comment #6

6 January 2017 at 18:13

The last submitted patch, 2: Resource-Caching-2825594.patch, failed testing.

Comment #7

6 January 2017 at 18:13

Status:

Needs review

» Needs work

The last submitted patch, 3: Resource-Caching-2825594.patch, failed testing.

Comment #8

kylebrowning CreditAttribution: kylebrowning as a volunteer and at Acquia commented 6 January 2017 at 18:15

Pretty sure this only failed because we have no tests.

Comment #9

lorenzs CreditAttribution: lorenzs at Cegeka commented 23 May 2017 at 10:49

Status:

Needs work

» Needs review

File	Size
services-resource_caching-2825594-9.patch	7.16 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.4 Composer require failure PHP 5.5 & MySQL 5.5, D8.3 Composer require failure PHP 5.5 & MySQL 5.5, D8.3 4 pass PHP 5.5 & MySQL 5.5, D8.3 4 pass

Tested it manually, fixed some typo's and added the no_cache property to the ServiceResource class (only had a getter function).
Also added a unit test for this class and renamed the patch.

For me this can go into the dev branch.