Problem/Motivation

Compatibility with metatags 8.x-1.0-beta-11 has been broken because of issue #2654148-34: Support for custom entities. It has been fixed on HEAD, but we don't know if a beta will be available soon.

Proposed resolution

Rename lingotek.entity.add_target route for preventing the bug.

Remaining tasks

Add patch with workaround and an upgrade test.

User interface changes

None.

API changes

None.

Data model changes

None

CommentFileSizeAuthor
#2 2825496-2.patch217.23 KBpenyaskito
#2 2825496-2.only-tests.patch214.38 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2825496-2.only-tests.patch214.38 KB
2825496-2.patch217.23 KB

Added patch with tests and only-tests patch

The last submitted patch, 2: 2825496-2.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Reviewed & tested by the community

Tests passed and failed as expected.

  • penyaskito committed a5be64c on 8.x-1.x 
    Issue #2825496 by penyaskito: Ensure compatibility with metatags 8.x-1.0...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed a5be64c and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.