In #2776787: Create IEF widget which allows to edit the media entities after the upload we introduced a really critical bug.

If you are using dropzonejs widget in EB with multistep selection, then every uploaded image will create 2 media entities.

Here is a patch: https://www.drupal.org/files/issues/create_ief_widget_which-2776787-36.p...

CommentFileSizeAuthor
#10 dropzonejs_in_eb-2825429-10.patch2.76 KBchr.fritsch
#6 interdiff-2825429-4-6.txt1.47 KBchr.fritsch
#6 dropzonejs_in_eb-2825429-6.patch2.71 KBchr.fritsch
#4 dropzonejs_in_eb-2825429-4.patch2.04 KBchr.fritsch
#3 create_ief_widget_which-2776787-36.patch.txt668 bytesPrimsi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Issue tags: +D8Media
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
FileSize
create_ief_widget_which-2776787-36.patch.txt668 bytes

Thanks for the patch (adding it to files so that testbot can see it). It would be great if somebody who uses this functionality could test it properly.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
dropzonejs_in_eb-2825429-4.patch2.04 KB

One thing was missing in the first patch. We have to clean up the form_state in clearFormValues.

Also i removed class property. There was no need for that

alduya’s picture

alduya CreditAttribution: alduya at 2DotsTwice bvba commented

The patch in #4 solves the problem for me.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
dropzonejs_in_eb-2825429-6.patch2.71 KB
interdiff-2825429-4-6.txt1.47 KB

Some additional work

If an Image is dropped into IEF Dropzone and then you are dropping another one before submitting, the second image will be used.

Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/modules/eb_widget/src/Plugin/EntityBrowser/Widget/DropzoneJsEbWidget.php
@@ -184,12 +175,21 @@ class DropzoneJsEbWidget extends WidgetBase {
+      } catch (\Exception $e) {}

Shouldn't we handle this exception?

Apart from that all seems to work normally as far as I could test. Thanks for the work!

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented

I am not sure how to handle it. The method is called twice, so on the second run it will always fail, because image is already moved. I don't know what we should do there

Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented

Hm, I was thinking, is this the right approach then? Can we fix this at the source of the problem (if possible) instead of fighting consequences?

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
FileSize
dropzonejs_in_eb-2825429-10.patch2.76 KB

Ok, i try to decouple all the patches.

So in this one i let the stuff for IEF Dropzone out.

Also i removed the try catch and added a check if the file exists.

  • Primsi committed 9899051 on 8.x-1.x authored by chr.fritsch 
    Issue #2825429 by chr.fritsch, Primsi: Dropzonejs in EB multi-step...
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs review » Fixed

Cool. Tested this with various widgets and it seems to fix the issue. Many thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.