Problem/motivation

We are creating a context object in #2803221: Create context value object for price resolvers and availability checkers, and the CountryContext and LocaleContext are not necessarily commerce contexts.

Proposed resolution

  1. Rename CountryContext to CurrentCountry
  2. Rename CountryContextInterface to CurrentCountryInterface
  3. Rename commerce.country_context service to commerce.current_country
  4. Rename LocaleContext to CurrentLocale
  5. Rename LocaleContextInterface to CurrentLocaleInterface
  6. Rename commerce.locale_context to commerce.current_locale

Remaining tasks

  1. Patch
  2. Passing tests
  3. Change record

Comments

steveoliver created an issue. See original summary.

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Issue summary: View changes
steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Status: Active » Needs review

https://github.com/drupalcommerce/commerce/pull/546 needs review after it passes.

  • bojanz committed dd9c837 on 8.x-2.x authored by steveoliver 
    Issue #2825066: Rename CountryContext and LocaleContext to...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Rename CountryContext and LocaleContext to CurrentUser and CurrentLocale » Rename CountryContext and LocaleContext to CurrentCountry and CurrentLocale
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Boom!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.