case 'comment':
        $default = array_merge($default, [
          'flagTypeCpnfig' => [

Will clash with #2716613: Action access control should be on a per FlagType basis. .

CommentFileSizeAuthor
#2 2824862-2.flag_.config-test-typo.patch463 bytesjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
2824862-2.flag_.config-test-typo.patch463 bytes
martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Good catch

Using git blame ... I can I see I alone was responsible for the screw up.

#2759417: Reduce the number of calls to FlagTestBase::createFlagWithForm() to make PHPUnit conversion easier

Oh well p is very close to o on the keyboard.

we have had this little bug since July 19, 2016

There is currently a giant finger hanging over my house pointing at me and a booming voice coming from the sky saying "it was YOU!!!"
which will probably disappear when my cheeks turn from red back to their normal colour. :)

joachim’s picture

joachim CreditAttribution: joachim commented

Looks like I reviewed several patches on that issue, so had maybe more than one opportunity to have spotted it! :)

  • joachim committed 0e7e70f on 8.x-4.x 
    Issue #2824862 by joachim: Fixed typo in config key in test.
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Reviewed & tested by the community » Fixed
martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented

so had maybe more than one opportunity to have spotted it! :)

I appreciate that ... but one does not get as far, in the theatre, as I have by being just a little bit histrionic!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.