Problem/Motivation

When there are multivalue fields that have changed, the summary might show the same label.

Proposed resolution

Us the delta for making the summary nicer.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

Status: Active » Needs review
FileSize
754 bytes
72.67 KB

Didn't know that the patch was so small. This might break some tests.

miro_dietiker’s picture

Status: Needs review » Needs work

For end users, number counts start at 1, so you would need to do +1 for number display.

Indexes are typically in square brackets such as:
Paragraphs [1] > Text
Math would put the index into lower, such as <sub> tag.
Paragraphs ₁
^ I think this is best. :-)

If not, we could try to remove that bracket noise completely:
Paragraphs > 1 > Text
Paragraphs - 1 > Text
Or even remove the Arrow noise too?
Paragraphs - 1 - Text
Or we could look at some extremely slim unicode arrows, just some quick examples, there are more:
➢ ⤇ ⦊ ⭢ ⮞

johnchque’s picture

Status: Needs work » Needs review
FileSize
1.32 KB
1.2 KB
66.21 KB

Tried with sub tag, looks good IMHO. :) Changed a bit the tags allowed.

johnchque’s picture

Now it starts with one. It compares the correct entities. Removed the arrow. Wondering if we should separate the fields with dash instead of comma?

johnchque’s picture

Imploding with dash instead. ;)

Status: Needs review » Needs work

The last submitted patch, 6: use_deltas_for-2824642-6.patch, failed testing.

johnchque’s picture

Status: Needs work » Needs review
FileSize
3.02 KB
982 bytes

As discussed using dash for separating fields. Fixed tests and improved the summary method a bit.

miro_dietiker’s picture

Status: Needs review » Fixed

OK Cool, committing.

Discussed follow-up: we should remove the index if cardinality 1.
And i still feel like the " - " can be more compact and make things more clearly belong together if we use a UTF-8 arrow and even remove the spaces...

johnchque’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.