Media items added or edited no longer displaying addition fields

Shot in the dark here, came up with a possible solution.

Here's a patch you can test out, can you kindly please apply it to your 7-x-2.0-beta-3 version of media and please re-test?

apply it like this:

cd media
wget https://www.drupal.org/files/issues/undefined_variable_langcode-2822662-4.patch
patch -p1 --dry-run < undefined_variable_langcode-2822662-4.patch
echo 'is there an error message on --dry-run?, if not, run next command'
patch -p1 < undefined_variable_langcode-2822662-4.patch

if you do not have the wget command you can supplement with curl as follows.
curl https://www.drupal.org/files/issues/undefined_variable_langcode-2822662-4.patch > undefined_variable_langcode-2822662-4.patch

the reason for the patch, is your environment appears to not use the i18n module and langcode was not defined, this patch hopefully will deal with this. If it works, I'll commit it and tag a new release.

Thanks,

hi @shelane please try patch 4 , updated steps are described in comment #2

I think all that is needed is to update the function signature? For instance I had this problem with metatag which was calling media with:

$value = media_wysiwyg_filter($value);

But I patched it to use full form:

$value = media_wysiwyg_filter($value, NULL, NULL, NULL, NULL, NULL);

However we shouldn't have to do this and the original method should still work. We just need to update media's token function.

The best solution is to just update the function signature for the params and set them to NULL as defaults which will prevent all warnings. I don't think any additional checks are necessary.

OK makes sense and thanks, @shelane, instead of patch 4, please try patch 6,

I tried to contact shelane but looks like her profile does not accept contact and thus she is likely not seeing our responses

I tested the scenario as best I could according to the explanation left by @shelane
I freshly installed Drupal 7.51 vanilla (french install, but monolingual, meaning there was only one language, no i18n and I did not install l10n)
installed prerequisites /dependencies for media
then installed the media version 7.x-2.0-beta3 and tested adding a new content type , then added an image field and assigned the media widget
added new content, did not see a problem

then I added a caption field (text field?) to the image file entity , added another piece of content, no problem

I could not reproduce the problem

Tested the same scenario with patch #6 applied, it works the same way, so either way it works.

I committed the patch by @sylus to 7.x-2.x dev as it didn't seem to have any issues and might help @shelane

Thanks.

need more precise steps to reproduce. Marking this as fixed, unless someone else can prove otherwise.

I tested again for good measure, this time an english d7 vanilla configuration, similar test case as I mentioned above.

Could not reproduce and works as designed. The use case scenario would have to be verbosely explained.

hi @shelane, thanks for the followup and thanks to @sylus for his patch.