Fix ViewModeTest [#2822368]

Problem/Motivation

From another issue's testbot output, Drupal\diff\Tests\ViewModeTest::testViewMode() is failing (not related to the fix of the other issue).

The first problem is because from a core commit (962eddec66f5542b4de206b0f2837a148ff686a1) they've added 'region' to kinda behave like the 'type' core.entity_view_display.*.*.* field (whether to display the field or not).

Another problem is probably that by assertNoText($value) in a page that compares two revisions where in the first one it has that $value, it doesn't work (?)
Not sure how it passed before that core commit or if it actually affect this test much that it breaks it...

Proposed resolution

- research
- discussion
- fix it

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#4	fix_viewmodetest-2822368-4.patch	495 bytes	tduong

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

26 October 2016 at 16:29

tduong created an issue. See original summary.

Comment #2

tduong CreditAttribution: tduong at MD Systems GmbH commented 27 October 2016 at 11:04

Based on the current head test, I've tried a git bisect setting the good core commit on one of the commits at 24th of October 2016, but I keep getting a failing test.

So I checked when was the last time that Drupal\diff\Tests\ViewModeTest::testViewMode() has been edited and as its testbot results on the 13th of October 2016 are all fine, I've checked out to the last core commit the day before

commit 55469c5016254cb8d02d8fbb3fc49d8ae8cb4c28
Author: Alex Pott <alex.a.pott@googlemail.com>
Date:   Wed Oct 12 15:29:44 2016 +0100

    Issue #2702969 by andrewmacpherson: Module filter does not announce number of results for screenreader when Toolbar module is disabled

But it still fails to check that 'Body', 'Foo' and 'Fighters'... now I guess it is something in the Diff scope.

Comment #3

tduong CreditAttribution: tduong at MD Systems GmbH commented 27 October 2016 at 11:11

Hmm just checked out to the

commit 4f5fe7912ea25c1ccca7908220889e7b605003ef
Author: git <git@3328253.no-reply.drupal.org>
Date:   Wed Oct 12 23:19:49 2016 +0200

    Issue #2817185 by yongt9412: Fix test fail in HEAD

in the Diff scope and ran the test but it fails (temporary fixing that 'fields[body][type]' to region), anayway...

Not sure what is the problem now..