[D8] Hide Path

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please do not assign tickat yourself. Please see See the workflow https://www.drupal.org/node/532400

Automated Review

Pareview: http://pareview.sh/pareview/httpgitdrupalorgsandboxpostfrosch2647974git

No issues found.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.
There is this similar module, but for Drupal 7: https://www.drupal.org/project/hide_filepath

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (+) .module file should be in the root of the project directory: https://www.drupal.org/docs/8/creating-custom-modules/a-practical-guide-...
2. (*) Installation and setup works. I can set the file formatter to an image field. I can save a node with the formatter in place. When I attempt to view a node I get the following fatal error: "PHP message: PHP Fatal error: Call to a member function buildUrl() on a non-object in /hipa/src/Controller/HipaController.php on line 33"

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi Postfrosch,

You make image style required. which is working fine, if we are updating the image style.

But by default "None (Original Image)" is selected. So in this case if we are not updating the default image style, Again we are getting fatal error: "PHP message: PHP Fatal error: Call to a member function buildUrl() on a non-object in /hipa/src/Controller/HipaController.php on line 33"

See the screenshot for default settings.

Manual Review;

1. viewElements(): After install and select Hide Path as display formatter for image field there is no image displaying. Please check the image style configuration value is empty. If empty set it as "default".
2. Project page too short: Add more information about your project. Refer Project page template.
3. Add configuration link in module info file. So that it will display in module listing page.
4. Found additional hipa.module file inside src folder. Please remove it from repository.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.