To convert to the new format now that hook_settings has been removed, and take advantage of the ability to have several settings pages.

Also convert the parameters URL to the new 4.8 (5.0) format.

Upstream: #173 / 2006-08-31 12:34:06 +0200

Issue fork g2-2822263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm created an issue. See original summary.

fgm’s picture

Issue summary: View changes
fgm’s picture

Parent issue: » #3362685: Port to Drupal 10
fgm’s picture

Version: 4.7.x-1.x-dev » 8.x-1.x-dev
fgm’s picture

Title: Remove g2_settings » Remove g2_admin_settings

Also g2_admin_settings_submit and g2_admin_settings_validate : those three functions belong in Drupal\g2\Form\SettingsForm

fgm’s picture

Status: Active » Needs work
FileSize
12.28 KB

First step: the main route, now with an auto-completion feature filtering out some unusable routes.

fgm’s picture

FileSize
18.79 KB

Converted the "main" settings.

fgm’s picture

FileSize
31.92 KB

Converted the formatting/tooltips and remote/client settings. More cleanup.

fgm’s picture

Status: Needs work » Needs review
FileSize
31.6 KB

Rerolled on 8.x-1.0-alpha1.

fgm’s picture

FileSize
46.75 KB

Converted the API settings, also fixed the majority of the XML-RPC functions.

fgm’s picture

FileSize
61.09 KB

Converted the homonyms settings, removed duplicating "entries" config, unneeded remote.local config, more cleanup.

fgm’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
66.75 KB

Completed conversion.

  • fgm committed 8bad5c3b on 8.x-1.x
    Issue #2822263 by fgm: Convert g2_admin_settings to SettingsForm.
    
fgm’s picture

Status: Reviewed & tested by the community » Fixed

Merged to current dev HEAD.

Harshita mehna made their first commit to this issue’s fork.

fgm’s picture

@Harshita mehna : this issue is fixed. Do not spend time on a fork. There are other live issues if you want to work on them :-)

volkswagenchick’s picture

@Harshita mehna
I see you have opened a merge request on an issue that is already closed. This creates unnecessary noise for the maintainers and anyone following an issue.

The amount of issues you have posted in the last few days leads other contributors to think you may be attempting to gamify the Drupal attribution system.

When you open a merge request or post a file it ticks the credit box for attribution and creates more work for maintainers when they close the issues. Please refrain from opening a merge request unless you are working on code.

I am going to go through some of the issues you are working on and give you individual examples on issue queue etiquette and how you can better improve your contributor experience working within the community.

Here is a list of resources to help you on your contribution journey, thanks!
Issue Queue Etiquette
Contributor tasks
Adding tags to issues and using tags

~AmyJune, Core Mentor and CWG Community Health team member

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.