Problem/Motivation

Disassociating translations fails if we get a 404 when it's setup to delete remote documents. We should assume it has been successfully deleted remotely.

Proposed resolution

Convert 404 exceptions to 404 responses.

Remaining tasks

Fix + tests

User interface changes

None

API changes

Created schema for config properties that didn't have them.
API addition: Added LingotekInterface::deleteDocument($doc_id). It was not in the interface.

Data model changes

None.

CommentFileSizeAuthor
#2 2822049-disassociating-2.patch20.82 KBpenyaskito
#2 2822049-disassociating-2.only-tests.patch17.18 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2822049-disassociating-2.only-tests.patch17.18 KB
2822049-disassociating-2.patch20.82 KB

Added patch + only tests patch.

The last submitted patch, 2: 2822049-disassociating-2.only-tests.patch, failed testing.

The last submitted patch, 2: 2822049-disassociating-2.only-tests.patch, failed testing.

The last submitted patch, 2: 2822049-disassociating-2.only-tests.patch, failed testing.

  • penyaskito committed 11155a6 on 8.x-1.x 
    Issue #2822049 by penyaskito: Fix disassociating translations fails if...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Reviewed & tested by the community

Tests passed and failed as expected.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed 11155a6 and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.