This is a sister issue to

#2821351: remove all direct references to $flag->id

I think the Flag:label property should be private rather than protected.

CommentFileSizeAuthor
#5 interdiff-2821923-2-5.txt388 bytesmartin107
#5 label-2821923-5.patch1.68 KBmartin107
#2 label-2821923-2.patch1.68 KBmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Assigned: martin107 » Unassigned
Status: Active » Needs review
FileSize
label-2821923-2.patch1.68 KB

Status: Needs review » Needs work

The last submitted patch, 2: label-2821923-2.patch, failed testing.

The last submitted patch, 2: label-2821923-2.patch, failed testing.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs work » Needs review
FileSize
label-2821923-5.patch1.68 KB
interdiff-2821923-2-5.txt388 bytes

Ah nuts, sorry for the distraction, I should have known better, back to protected.

  • socketwench committed 619f7c4 on 8.x-4.x authored by martin107 
    Issue #2821923 by martin107: Removed direct references to Flag::label.
socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Needs review » Fixed

Thanks, Martin!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.