Change for hook comment formatting was discussed in #2623718: Fix 'Drupal.Commenting.HookComment' coding standard to allow text other than a filename or function to be specified after ”for”.

CommentFileSizeAuthor
#2 2821834-2-hookcomment_formatting_change.patch1.65 KBZeiP
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ZeiP created an issue. See original summary.

ZeiP’s picture

ZeiP CreditAttribution: ZeiP as a volunteer and at Citrus Solutions Oy commented
FileSize
2821834-2-hookcomment_formatting_change.patch1.65 KB

Attached is a patch to do this.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Makes sense, can you add an example to good.php and file a pull request against https://github.com/klausi/coder ?

ZeiP’s picture

ZeiP CreditAttribution: ZeiP as a volunteer and at Citrus Solutions Oy commented
Assigned: Unassigned » ZeiP

Sure, I'll get on that.

ZeiP’s picture

ZeiP CreditAttribution: ZeiP as a volunteer and at Citrus Solutions Oy commented
Status: Needs work » Needs review

The pull request is at https://github.com/klausi/coder/pull/16 .

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Needs work

Almost ready, left a minor comment on the PR.

  • klausi committed 3749cdc on 8.x-2.x authored by ZeiP 
    fix(HookCommentSniff): Allow doc block comments about hooks with...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs work » Fixed
Issue tags: -Needs tests

Merged after the update, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.