CommentFileSizeAuthor
#6 2821772-pager-tests.patch3.24 KBeojthebrave
#5 interdiff-2821772-02-05.txt1.1 KBphoenix5037
#5 examples.pager_example_phpunit_conversion_2821772_05.patch3.36 KBphoenix5037
#2 examples.pager_example_phpunit_conversion_2821772_02.patch3.42 KBrfay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay created an issue. See original summary.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
FileSize
examples.pager_example_phpunit_conversion_2821772_02.patch3.42 KB
rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: examples.pager_example_phpunit_conversion_2821772_02.patch, failed testing.

phoenix5037’s picture

phoenix5037 CreditAttribution: phoenix5037 as a volunteer commented
Status: Needs work » Needs review
FileSize
examples.pager_example_phpunit_conversion_2821772_05.patch3.36 KB
interdiff-2821772-02-05.txt1.1 KB

From https://www.drupal.org/node/2821387,

I also encountered this on testing:

Behat\Mink\Exception\ExpectationException: Link containing href ?q=%2Fexamples%2Fpager-example&page=1 found.

Changing the link string back to ?page=1 passes the test on my machine.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
CreditAttribution: eojthebrave at Drupalize.Me commented
Status: Needs review » Reviewed & tested by the community
FileSize
2821772-pager-tests.patch3.24 KB

I was able to run these tests locally and they work. This patch just fixes a couple of minor documentation issues. I would say this is ready to go. Thanks @rfay and @phoenix5037.

  • Torenware committed 75b93c7 on 8.x-1.x authored by eojthebrave 
    Issue #2821772 by phoenix5037, rfay, eojthebrave: Convert pager_example...
Torenware’s picture

Torenware CreditAttribution: Torenware as a volunteer commented
Status: Reviewed & tested by the community » Fixed

And it's a wrap folks. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.