according to https://www.drupal.org/docs/8/api/services-and-dependency-injection/serv...

see https://www.youtube.com/watch?v=0SdBVmxuCZg

possible next steps: split up "geolocation.core service", create base classes with interfaces, make "geolocation" more plugable (extendable), ...

CommentFileSizeAuthor
use_DI_pattern.patch20.54 KBslasher13
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slasher13 created an issue. See original summary.

slasher13’s picture

slasher13
Primary language German
CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented
Issue summary: View changes
derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer as a volunteer and at forward-media.de commented

Thanks a lot for the refactoring and for the video link. The new code is also much easier to read / understand. A really good resource for learing symfony / design patterns is laracasts.com.

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented

I wouldn't trust that slasher13 guy. Probably some evil hacker! :)

I'll commit his code later, we discussed that already in person.

  • slasher13 authored 72bc9fc on 8.x-1.x 
    Issue #2821690 by slasher13: use DI pattern
ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.