Minimum keyword size is ignored, and activates after one character

Confirming same issue as reported above with the search block and autocompletion_callbacks_words::words_autocompletion_callback as the callback.

Frequently results in the user getting the warning message on the subsequent page load.

You must include at least one keyword to match in the content. Keywords must be at least 3 characters, and punctuation is ignored.

Thanks

Hi ! thanks for reporting, I will have a look as soon as possible.

Hi,

I have created patch, in which minimum character has been validate to activate the result.
PFA of patch file.

Thanks

Possible duplicate: https://www.drupal.org/node/2839543

Hi sittard,

I have checked the patch given in 'Possible duplicate: https://www.drupal.org/node/2839543'. But those changes are related to setting 'maximum number of suggestion to display' not to 'minimum number of character a user must input before auto completion starts'.

I think this issue is related to restrict the number character user enters in search textbox. So Please go through the patch which is have created in comment #5.

Thanks

On further reading I see you are correct - thanks.

@Ujwala_D,Thanks! for the patch, it works well, but face some issue during RTBC
like.1) When I tried autocomplete functionality with Tags Field it didn't work for me Also there is no option to check for "Use Autocomplete".
2) When I use filter with Body it shows <P> tag with suggested value.PFA

Hi Jigar.addweb,

Thanks to make this patch perfect. As you mentioned in comment #9,I could not reproduce the #2 point Otherwise,I have done with solution.PFA

Thanks

@Ujwala_D,Thanks! for the patch solution it works for tag field now but when i use it it shows me count with results.

Steps to reproduce #2 issue :-

1) Install Search Auto complete and view auto complete filters and enable it.

2) Create new view.

3) Add fields for like title, body and tags.

4) Create Expose Filter for body,Title & tag field. Select operator as "contains" from drop down.

5) In the filter settings also select use auto select checkbox, and also set minimum number of characters to start filter as 3.

6) Save that View.

7) In Body filter write content and you will see

tags in textbox, if you select that value as a selected value it reflects

with that value also.

Note : For better clarity i can provide you my simplytestMe link if you want.

Hi Jigar.addweb,

I able to reproduce the issue for body field with 'minimum number of character to start filter' settings. But This issue is related to 'views autocomplete filters' module not to search autocomplete module.
So you can raise same issue for 'views autocomplete filters' module.
One more thing, regarding the showing count with result in tags fields, Its a drupal default behaviour, Even if you uninstall the search autocomplete module, It remain same as you get before.

Still you have any issue let me know.

Thanks

This patch is working for me. It sounds like the issue above should be addressed somewhere else. Thanks for your work on this!

1. +++ b/js/jquery.autocomplete.js
   @@ -104,14 +104,22 @@
   +        response(suggestions);
   +      }else{
   +        suggestions = [];
   +        response(suggestions);
          }
   -      response(suggestions);
   

   Keep the last response(suggestions) since it is done in each cases

2. +++ b/js/jquery.autocomplete.js
   @@ -104,14 +104,22 @@
   +      var taggedChar = request.term;
   +      var minChar = autocomplete.options.forms[key].minChars;
   +      if(taggedChar.length >= minChar){
   +
   +        var tagged = autocomplete.splitValues(request.term);
   +        for (var i = 0, il = tagged.length; i < il; i++) {
   +          var index = suggestions.indexOf(tagged[i]);
   +          if (index >= 0) {
   +            suggestions.splice(index, 1);
   +          }
            }
   +        response(suggestions);
   +      }else{
   +        suggestions = [];
   +        response(suggestions);
   

   This seems useless since if here, we should allow autocompletion. 'search' event, handled via 'searchHandler' method is here to ensure that.

   Best would be to personnalize minLength value per instance, just how it is done for blacklist characters.

3. +++ b/search_autocomplete.libraries.yml
   @@ -7,4 +7,9 @@ search_autocomplete.admin.helper:
   -    - core/drupal
   ...
   +    - core/drupal
   +    ¶
   +search_autocomplete.user.search_helper:
   +  version: VERSION
   +  js:
   +    js/jquery.autocomplete.js: {}
   
   +++ b/search_autocomplete.module
   @@ -176,17 +176,6 @@ function search_autocomplete_library_info_build() {
   - * Implements hook_library_info_alter().
   - */
   -function search_autocomplete_library_info_alter(array &$libraries, $extension) {
   -  if ($extension == 'core' && isset($libraries['drupal.autocomplete'])) {
   -    $libraries['drupal.autocomplete']['js'] = array(
   -      '/' . drupal_get_path('module', 'search_autocomplete') . '/js/jquery.autocomplete.js' => array(),
   -    );
   -  }
   -}
   -
   -/**
   
   @@ -237,6 +226,7 @@ function search_autocomplete_form_alter(&$form, \Drupal\Core\Form\FormStateInter
   +    $form['#attached']['library'][] = 'search_autocomplete/search_autocomplete.user.search_helper';
   
   @@ -244,6 +234,7 @@ function search_autocomplete_form_alter(&$form, \Drupal\Core\Form\FormStateInter
   +    $form['#attached']['library'][] = 'search_autocomplete/search_autocomplete.user.search_helper';    ¶
   

   Should not be here. How JS is added is another issue.

According to my review in comment #14:
For me patch #10 is not a proper solution. The workflow is that search event is triggered if options passes (minLength included), then the HTTP request to get the results is performed. After that the patch adds another check for minLength to eventually cancel the autocompletion. This is odd and has poor performance.

Better would be to customize minLength value per instance (just has done with "firstCharacterBlacklist"), thus it would be included in 'search' event verif, before AJAX call is done.

Here is a patch attached with this approach.

Changed the test to actually be compatible with core autocomplete.

I agree with @Dom - As a quick fix we also changed jquery.autocomplete.js

    // Only search when the term is at least the minimum length.
    return term.length >= options.minLength;

to:

    // Only search when the term is at least the minimum length.
    return term.length >= 3;

That seems to work but obviously the patched solution should get the minLength from the configuration.

Thanks.

@sittard: the patch I provide at #16 has a configurable minLength.

Patch in #16 works fine for me.

@ressa there are multiple people reporting on the patch fixing the problem, I think this is still valid bug.

@ressa: I am also facing this issue still. Minimum keyword size was set to 3 in configuration but suggestions were activating after entering a single character. #16 fixed it.

Thanks a lot for help and review.