INTRODUCTION

Drupal 7.42 release breaks autocomplete functionality on certain unusual server configurations that block direct access to Drupal's index.php file.

This module fixes autocomplete functionality on environments with restricted access to index.php.

Don't use this module if your server doesn't block direct access to Drupal's index.php file.

INSTALLATION

Install as usual, see https://drupal.org/documentation/install/modules-themes/modules-7 for further information.
Go to "Administer" -> "Modules" and enable the Autocomplete Unblock module.

TROUBLESHOOTING

Autocomplete Unblock module doesn't provide any visible functions to the user on its own, it
just implements hook_url_outbound_alter() to fix autocomplete functionality
on environments with restricted access to index.php.

PROJECT PAGE

This sandbox project is located at https://www.drupal.org/sandbox/irystonnet/2821464

GIT CLONE COMMAND

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/iryston.net/2821464.git autocomplete_unblock
cd autocomplete_unblock

PAREVIEW

http://pareview.sh/pareview/httpgitdrupalorgsandboxirystonnet2821464git

RELATED ISSUES

https://github.com/perusio/drupal-with-nginx/issues/235
https://github.com/perusio/drupal-with-nginx/pull/249
https://github.com/perusio/drupal-with-nginx/pull/261
https://www.drupal.org/node/2599326
https://www.drupal.org/node/2749007

Comments

iryston created an issue. See original summary.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Konstantin Komelin’s picture

Hi @iryston,

Thank you for the module. It should be useful for Nginx sites that are using perusio's config.

Please collect and provide links to the related issues on Github and on Drupal.org. There are a few, for example: https://github.com/perusio/drupal-with-nginx/issues/235

One question, why did you give the module such name? I mean it would be good to have the main feature in the name, for example "autocomplete_fix" or "7_42_autocomplete_cure" or something like that. Easier to find and remember what it does.

Thanks,
Konstantin

iryston’s picture

Title: [D7] Seqlean » [D7] Autocomplete Unblock
Issue summary: View changes
iryston’s picture

Issue summary: View changes
iryston’s picture

Hi @konstantin-komelin,

Thank you for advises.
Links to the related issues on Github and on Drupal.org are now provided.
Also, the module is renamed.

Thanks,
Igor

Konstantin Komelin’s picture

Thank you @iryston for your updates. Additionally, the module is now in the Security category but I don't see a direct relation to security. It's rather Utility module. Agree?

Now you may want to obtain review bonus. In other words, you review other projects in the Project Application Queue and somebody else reviews your module in response. Learn more here https://www.drupal.org/node/1975228

When I have time I will try your module on one of my projects and report here about results.

deminy’s picture

Using this module on my personal website (deminy.net) and looks great.

+1

apaderno’s picture

Priority: Normal » Critical

To the reviewers: Please set the priority to Normal after reviewing the project.

sleitner’s picture

Priority: Critical » Normal
Status: Needs review » Needs work

Automated Review

Review of the 7.x-1.x branch (commit 9a347d0):

  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The REQUIREMENTS section is missing.
    • The CONFIGURATION section is missing.
  • The autocomplete_unblock.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     25 | WARNING | Line exceeds 80 characters; contains 92 characters
    --------------------------------------------------------------------------
    
    Time: 250ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity. Too few code
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.