Love this module!
I have a request for a minor change. When the module adds the required attribute to required form fields, it sets it to “true” which is incorrect. According to W3C guidelines:
“The presence of a boolean attribute on an element represents the true value, and the absence of the attribute represents the false value. The values “true” and “false” are not allowed on boolean attributes. To represent a false value, the attribute has to be omitted altogether.”
This means the value for the required attribute either shouldn’t be set or if it is, it’s set to “required” instead of “true”.
I'll attach a patch below.
Comment | File | Size | Author |
---|---|---|---|
#2 | accessible_forms-required_attribute_value-2821369-1-v7.patch | 714 bytes | micnap |
Comments
Comment #2
micnap CreditAttribution: micnap at Mediacurrent commentedComment #3
kim.pepperLGTM
Comment #5
kim.pepper