Here are all the instances I could find (a few false positives in there):

$ ag 'flag..id[^(]'
flag.module
421:      $flag_keys[] = $flag->id . '-' . $action;

src/FlagServiceProvider.php
22:    $container->setDefinition("flag.$id", $original_definition);
23:    $new_definition = new Definition('Drupal\flag\Access\CsrfAccessCheck', [new Reference("flag.$id"), new Reference('current_user')]);

src/Form/FlagFormBase.php
65:    $form['#flag_name'] = $flag->id;
80:      '#default_value' => $flag->id,
330:    if ($flag->id != $form['#flag_name']) {
CommentFileSizeAuthor
#5 2821351.5.protectedFlagID.patch2.77 KBsocketwench
#2 2821351.2.protectedFlagID.patch2.06 KBsocketwench
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Active » Needs review
FileSize
2821351.2.protectedFlagID.patch2.06 KB

Imported Flag::id changes from #2821272: Flag - protect weight and uuid

Status: Needs review » Needs work

The last submitted patch, 2: 2821351.2.protectedFlagID.patch, failed testing.

The last submitted patch, 2: 2821351.2.protectedFlagID.patch, failed testing.

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Needs work » Needs review
FileSize
2821351.5.protectedFlagID.patch2.77 KB

Fix for FlagViewsReleationship.

  • joachim committed 6e93e43 on 8.x-4.x authored by socketwench 
    Issue #2821351 by socketwench: Changed $flag::id to protected, in...
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.