Replace #tag => meta usages with #type => meta

Replacing the occurrences of #tag => meta with #type => meta wherever found.

Not replaced the concurrences of

'#type' => 'html_tag',     
 '#tag' => 'meta'

not sure what needs to be done in this case.

@joelpittet Patch #6 was for Replacement of #tag => meta with #type => meta

#5 Looks sane to me...

#5 is the correct patch.

#6 is not quite right because the code in system.module looks like this after applying it (notice the double #type key):

    'system_meta_generator' => array(
      '#type' => 'html_tag',
      '#type' => 'meta',
      '#attributes' => array(
        'name' => 'Generator',
        'content' => 'Drupal ' . $version . ' (https://www.drupal.org)',
      ),
    ),

The issue is quite trivial, and in my opinion, #5 can be accepted as is but I have still changed a couple of things:

• added tests to specifically check the rendering of meta element;
• removed description of #noscript property from documentation of Meta class (because meta tag cannot have a value);
• removed meta tag from $voidElements list in HtmlTag class, so that its ability to render meta does not look like an undocumented feature.

Updated patch because previous patch failed to apply to 8.4.x branch.

Any Update on this issue ?

Patch #20 still applies cleanly, and it makes sense. Can't think of anything else to do here so RTBCing.

This is doing more than replacing usages so should probably be retitled (and issue summary updated) accordingly.

1. +++ b/core/lib/Drupal/Core/Render/Element/HtmlTag.php
   @@ -40,7 +40,7 @@ class HtmlTag extends RenderElement {
   -    'keygen', 'link', 'meta', 'param', 'source', 'track', 'wbr',
   +    'keygen', 'link', 'param', 'source', 'track', 'wbr',
   

   Not sure about this change for backwards compatibility. What about people that would still be using #tag => meta? If we want to deprecate that, can we trigger an error when they use #tag => meta so that we can remove it in 9.x?

2. +++ b/core/lib/Drupal/Core/Render/Element/Meta.php
   @@ -0,0 +1,40 @@
   + * Properties:
   + * - #attributes: (array, optional) HTML attributes to apply to the tag. The
   + *   attributes are escaped, see \Drupal\Core\Template\Attribute.
   

   Since we're extending HtmlTag, the properties should also include #noscript.

Created Patch for D9.1 kindly check.

Patch #30 works fine on 9.1
RTBC + 1

Applied patch #30 and its applies cleanly.The #tag => meta is removed with #type => meta ,and also updated in test cases.

#30 giving 1 CS issues.

In lib/Drupal/Core/Render/Element/Meta.php, I think it should be

  protected static $voidElements = ['meta'];

instead of

 static protected $voidElements = ['meta'];

yes it should be
protected static $voidElements = ['meta'];

Updated patch. Please review.

Applied patch #30 applied successfully
Thanks for the patch

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.