Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
I have added manualcrop to the oa_banner image_style
I have uploaded a banner.
I hit manual crop
It saves the area.
I hit the save button for media browser.
I then hit the save button for the space.
The manualcrop image is not used. Only the original is used.
I am not sure if it is a conflict with the scale (800x200)
Comment | File | Size | Author |
---|---|---|---|
#6 | Screenshot-manualcrop_work_with_oa_banner-2821166-4-patched.png | 169.25 KB | magulaiz |
#6 | Screenshot-manualcrop_work_with_oa_banner-2821166-4.png | 184.23 KB | magulaiz |
#5 | manualcrop_work_with_oa_banner-2821166-4.patch | 1.98 KB | magulaiz |
Comments
Comment #2
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedargghhhh... how do I remove crop? That is a horrible UI experience. Let's just remove it from media when it is called for the oa_banner field
Comment #3
mpotter CreditAttribution: mpotter at Phase2 commentedI'm sure you can just disable the crop module if you don't want it, or edit the specific field and disable crop for that field. But this module integration with Media comes from Panopoly so any feedback on how it is used should go there or directly to the specific crop module issue queue. If there is something that needs to be fixed specifically in Atrium then patches are welcome.
Comment #4
magulaiz CreditAttribution: magulaiz commentedI've found the same problem. Here it is how you can solve it hacking the OpenAtrium code, waiting for a right patch:
Module: oa_appearance
version: 7.x-2.7
File: /OPENATRIUM_ROOT/profiles/openatrium/modules/apps/oa_appearance/plugins/content_types/oa_space_banner.inc
File: /OPENATRIUM_ROOT/profiles/openatrium/modules/apps/oa_appearance/oa_appearance.module
NOTE: This solution only has sense on setting "Banner Position" to "Below toolbar (Stretched)"
Comment #5
magulaiz CreditAttribution: magulaiz commentedPatch against oa_appearance 7.x-2.x, according to previous comment.
Comment #6
magulaiz CreditAttribution: magulaiz commentedTesting patch ...
Comment #7
mpotter CreditAttribution: mpotter at Phase2 commentedWhile this is likely a good idea, I cannot go with this solution because it could break existing sites. The banner image was specifically designed to display the exact banner image that was uploaded with no image_style modifications. The panopoly_image_full image style used in this patch scales the width to 960, so would break existing site banner images.
To really fix this and support cropping, need to create a new image style that doesn't modify the image except to enable the cropping plugin.