Hi,

I'm using the module on an international site to expose a form for subscription.
I've enabled the MailChimp Signup module, and enabled the block generated on my footer region.

I'd like to translate the label generated by the module "Email Address" in french. But the string is not available in the translation interface.
It is possible to enable the translation for the fields generated in these forms ?

Screenshot added with my block configuration and its position in my site in the French version.

CommentFileSizeAuthor
#10 13082807-10.patch407 bytessamuel.mortenson
#5 translation-for-email-address-label-unavailable-2821153-5.patch488 bytesasrob
#3 translation_for_email-2821153-3.patch952 bytesjuampynr
#2 translation-for-email-address-label-unavailable-2821153-2.patch488 bytesasrob
screenshot-asplamagnifique.png99.44 KBasplamagnifique
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

asplamagnifique created an issue. See original summary.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Version: 8.x-1.2 » 8.x-1.x-dev
Status: Active » Needs review
FileSize
translation-for-email-address-label-unavailable-2821153-2.patch488 bytes

Added a small patch to translate "Email Address" label.

juampynr’s picture

juampynr CreditAttribution: juampynr at Lullabot commented
FileSize
translation_for_email-2821153-3.patch952 bytes

Re-rolling patch. Works for me after I updated it against 8.x-1.x.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody as a volunteer and commented

Please see https://www.drupal.org/node/2822227#comment-11836593 for further discussion also.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
FileSize
translation-for-email-address-label-unavailable-2821153-5.patch488 bytes

Updated my patch.

  • asrob authored a6327f3 on 8.x-1.x 
    Issue #2821153 by asrob, juampynr, asplamagnifique: Translation for...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Fixed

Thanks all!

cwarts’s picture

cwarts CreditAttribution: cwarts commented

Hello,

i´ve just tested the patch and want to inform you that it doesn´t work.

When i open the subscription form i see the following error message:

"InvalidArgumentException: $string ("Email Address") must be a string. in Drupal\Core\StringTranslation\TranslatableMarkup->__construct() "

Can you plz check this again?

Thanks

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Fixed » Needs work

Putting in needs work for #8, I'll look into this.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs work » Needs review
FileSize
13082807-10.patch407 bytes

@cwarts Could you try this patch and let me know if it resolves you issue?

cwarts’s picture

cwarts CreditAttribution: cwarts commented

Hi,

i applied the patch in #5 and #10 and now it works :-)

Thank you

  • 8323f6b committed on 8.x-1.x 
    Issue #2821153 Follow up.
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.