Running our CI over a multilingual drupal site we saw this issue with Devel Node access.

Drupal\KernelTests\Core\Config\DefaultConfigTest::testDefaultConfig
Schema key devel_node_access.settings:langcode failed with: missing schema

Adding the schema key fixed this, and a patch is attached for this

CommentFileSizeAuthor
#7 devel_node_access_schema_langcode.patch543 bytesTom.W
#6 devel_node_access_schema_langcode.patch547 bytesTom.W
devel-8.x-1.x-langcode-schema.patch543 bytesTom.W
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Tom.W created an issue. See original summary.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Project: Devel » Devel Node Access
Component: devel_node_access » Code

@Tom.W thanks for reporting.
DNA for D8 has temporarily moved to its own project until it's ready. Moving the issue to DNA issue queue

Tom.W’s picture

Tom.W CreditAttribution: Tom.W commented

no problem. Does the above patch work for you? Seemed to solve the issue on my copy

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Active » Needs review

Patch doesn't apply here, let's get testbot triggered still.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Needs work

ah, no testbot here.. Patch still needs reroll.

Tom.W’s picture

Tom.W CreditAttribution: Tom.W at PwC's Experience Center commented
FileSize
devel_node_access_schema_langcode.patch547 bytes

Rerolled patch for new module, should apply cleanly now

Tom.W’s picture

Tom.W CreditAttribution: Tom.W at PwC's Experience Center commented
FileSize
devel_node_access_schema_langcode.patch543 bytes

sorry, noticed issue with indentation after i uploaded, cleaned it up in this one. It applies for me (using patching via composer) so let me know if you have any issues

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs work » Postponed (maintainer needs more info) 
+++ b/devel_node_access/config/schema/devel_node_access.schema.yml
@@ -4,6 +4,9 @@ devel_node_access.settings:
+    langcode:
+      type: string
+      label: 'Language Code'

I'm confused—where is this used? DNA has no such setting.

In fact, DNA has no tests, which is why we can't run testbot on it.

Was this issue somehow related to DNA being part of Devel?

Tom.W’s picture

Tom.W CreditAttribution: Tom.W at PwC's Experience Center commented

Schema testing is a core test that runs over every module on a site and checks for the schema existing and being correct, so although its not part of the module itself your module does get tested.
See \Drupal\KernelTests\Core\Config\DefaultConfigTest

Tom.W’s picture

Tom.W CreditAttribution: Tom.W at PwC's Experience Center commented
Status: Postponed (maintainer needs more info) » Needs work
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

Yes, but there's no langcode setting in DNA.

Tom.W’s picture

Tom.W CreditAttribution: Tom.W at PwC's Experience Center commented

and that is why it fails..... The schema test always requires you to have a langcode of some kind defined. Maybe that makes this an error in that test ;) but the easy fix is to add the key as per the patch above

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

Ok, I'll add it, thanks!

Would you have a pointer to where this is documented? Do I need to set a certain value, given that DNA doesn't care about language?

P.S. Right now there's still an issue with the testbot: #2853814: Composer require failure: Devel vs. Devel Node Access