Problem/Motivation

#2421431: Add EntityInterface::validate() introduces for raw mail messages by following RFC standards.

Proposed resolution

However, we are wrongly asserting "Received" field instead of "Date" field.
Improve tests.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#10 fix_wrong_validation-2821018-10-interdiff.txt2.05 KBmbovan
#10 fix_wrong_validation-2821018-10.patch8.72 KBmbovan
#6 fixed_wrong_validation-2821018-6-interdiff.txt2.09 KBmbovan
#6 fixed_wrong_validation-2821018-6.patch8.55 KBmbovan
#6 fixed_wrong_validation-2821018-3-TEST-ONLY.patch446 bytesmbovan
#3 fixed_wrong_validation-2821018-3.patch7.47 KBmbovan
#3 fixed_wrong_validation-2821018-3-TEST-ONLY.patch446 bytesmbovan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Assigned: Unassigned » mbovan
Priority: Normal » Major

While working on #2820989: Identify message body content I couldn't process the message and ended up creating the bug report.

Raising it to "Major" since processing messages with multiple "Received" headers happens quite often.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Active » Needs review
FileSize
fixed_wrong_validation-2821018-3-TEST-ONLY.patch446 bytes
fixed_wrong_validation-2821018-3.patch7.47 KB

Improved validation, fixed wrong field, improved tests.

One-line test-only should be enough for a fail.

The last submitted patch, 3: fixed_wrong_validation-2821018-3-TEST-ONLY.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: fixed_wrong_validation-2821018-3.patch, failed testing.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
fixed_wrong_validation-2821018-3-TEST-ONLY.patch446 bytes
fixed_wrong_validation-2821018-6.patch8.55 KB
fixed_wrong_validation-2821018-6-interdiff.txt2.09 KB

More Received/Date replacements.

The last submitted patch, 6: fixed_wrong_validation-2821018-3-TEST-ONLY.patch, failed testing.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Title: Fixed wrong validation field assertion » Fix wrong validation field assertion
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Needs work 
  1. +++ b/inmail_demo/eml/simple.eml
@@ -1,5 +1,5 @@
-Received: from mail.example.com; Wed, 27 May 2015 15:42:10 +0200 (CEST)
+Date: Wed, 27 May 2015 15:42:10 +0200 (CEST)

    Don't remove it, add it. 

  2. +++ b/src/MIME/Message.php
@@ -46,24 +46,22 @@ class Message extends Entity implements MessageInterface {
+        $this->setValidationError($field_name, "$count $field_name fields.");

    This doesn't explain what is wrong with the count.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
fix_wrong_validation-2821018-10.patch8.72 KB
fix_wrong_validation-2821018-10-interdiff.txt2.05 KB

Addressed #9.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.