CommentFileSizeAuthor
#6 t_2821015_6.patch3.24 KBbandanasharma
#3 after-patch.png35.03 KBbandanasharma
#3 before-patch.png24.72 KBbandanasharma
#2 t_2821015_1.patch3.5 KBnehakhadke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke commented
FileSize
t_2821015_1.patch3.5 KB
bandanasharma’s picture

bandanasharma CreditAttribution: bandanasharma as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Active » Reviewed & tested by the community
FileSize
before-patch.png24.72 KB
after-patch.png35.03 KB

#2 patch is apply success fully. Attached before and after screen shot.

gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Reviewed & tested by the community » Needs work

Thank you for contribution.

Please remove translation from the names.
I believe nobody wants to translate silly names like "X VTabs", etc. ;)

gausarts’s picture

gausarts CreditAttribution: gausarts commented

You also want to import the translation trait.

bandanasharma’s picture

bandanasharma CreditAttribution: bandanasharma as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
t_2821015_6.patch3.24 KB

In the patch remove translation from the names.

bandanasharma’s picture

bandanasharma CreditAttribution: bandanasharma as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Needs review » Needs work

Thank you. Almost there ;)

BTW, the skins are cached.
Have you tried clearing cache, and visit any page containing Slick with those skins?

If you see any issue, please see comment #5 for solution.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Needs work » Closed (won't fix)

Please read my previous comments: clear your cache, and find your site containing slicks broken.

Breaking a module is human. Fixing it requires a little internal diving, and a little love.

Feel free to re-open when you have those little things, and fix what you have broken with your patch.
Thank you for contribution, anyway.