[D7] Animate Any

Module is working fine, but still some issues in http://pareview.sh/pareview/httpsgitdrupalorgsandboxvirajr2621132git.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Thanks for your participation, but I'm afraid the comments you did are not very detailed and not really "reviews". Removing review bonus tag. Make sure to read through the source code of the project. For more detail please go here https://www.drupal.org/node/1975228.

Hello,
Please check issues below:

1) Right after installation on the clear Drupal I got a notice

Notice: Undefined index: data in drupal_process_attached() (line 4642 of /path/to/drupal/includes/common.inc).

2)

  $items['admin/config/animate_any/add'] = array(
    'title' => 'Add',
    'type' => MENU_DEFAULT_LOCAL_TASK,
    'weight' => 2,
  );

How should it work? It should create empty local task on the page? As for me - this menu item is useless.

3)

  $form['animate_fieldset'] = array(
    '#prefix' => '<div id="item-fieldset-wrapper">',
    '#suffix' => '</div>',
    '#tree' => TRUE,
    '#theme' => 'table',
    '#header' => array(),
    '#rows' => array(),
    '#attributes' => array('class' => 'animation'),
  );

Please use drupal_html_id() funciton for IDs definition. The same for "
"
BTW it defines more that 1 H1#animate on the page, it could be a problem for some JS frameworks.

4)

    $form['animate_fieldset'][$key] = array(
      'section_identity' => &$section_identity,
      'section_animation' => &$section_animation,
      'animation' => &$animation,
    );

I didn't find that this values should be passed with &. Probably I have missed something? Could you clarify?

5) Seems functional of this module isn't working. I'm unable to save anything using form.

6)

      if (empty($value['section_identity'])) {
        form_set_error("animate_fieldset][{$key}][section_identity", t("Please select section identity for row @key", array('@key' => $key)));
      }
      if ($value['section_animation'] == 'none') {
        form_set_error("animate_fieldset][{$key}][section_animation", t("Please select section animation for row @key", array('@key' => $key)));
      }

You can use $form_error($form['animate_fieldset'][$key][section_animation]); instead. It will be more clear for code reading.

7)

/**
 * Implements hook_page_build().
 */
function animate_any_page_build(&$page) {

  $path = drupal_get_path('module', 'animate_any');
  $fetch = db_select("animate_any", "a");
  $fetch->fields('a');
  $fetch_results = $fetch->execute()->fetchAll();
  $json_data = json_encode($fetch_results);
  $page['#attached']['css'][] = $path . '/css/animate.css';
  $page['#attached']['js'][] = $path . '/js/animate_any.js';
  $page['#attached']['js'][] = array('animate_any' => array('animation_data' => $json_data), 'type' => 'setting');
}

Missing "Data" element in the array. It generates errors. (See point 1)

8) animate_any_options() creates a list of the methods -> names. Please consider add a drupal_alter for this data.

9)

/**
 * Implements Delete Aminate Submit.
 */
function animate_any_delete_animate_block_submit($form, &$form_state) {
  $animate_aid = $form_state['values']['animate_aid'];
  if (is_numeric($animate_aid)) {
    $delete = db_delete('animate_any')->condition('aid', $animate_aid)->execute();
    if ($delete) {
      drupal_set_message(t('Record deleted successfully.'));
    }
    drupal_goto('admin/config/animate_any/list');
  }
}

Please use $form_state['redirect'] intead of "drupal_goto()"

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.