I'm not exactly sure what is producing this error as it occurs on a site with content and several experimental modules installed like (content_moderation and multiversion).
I couldn't reproduce it in a clean install.

Fatal error: Using $this when not in object context in domain/domain_access/src/DomainAccessManager.php on line 101

CommentFileSizeAuthor
#6 fatal_error_when-2820932-6.patch602 byteshostdog
#2 fatal_error_when-2820932-2.patch565 byteshostdog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hostdog created an issue. See original summary.

hostdog’s picture

hostdog CreditAttribution: hostdog commented
Issue tags: +Quick fix
FileSize
fatal_error_when-2820932-2.patch565 bytes

Replace $this with self:: at static function getDefaultValue

hostdog’s picture

hostdog CreditAttribution: hostdog commented

I think we have to alter the getDefaultValue function to public, self::getAccessValues($entity) is producing the following warning.

Strict warning: Non-static method Drupal\domain_access\DomainAccessManager::getAccessValues() should not be called statically in Drupal\domain_access\DomainAccessManager::getAccessValues()

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

I'll see if I can reproduce, but the error is nice and specific.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

This is odd, because as far as I can tell -- and the code comment says -- that else statement never fires.

And the getDefaultValues method is already public. Not sure there is anything to do here.

hostdog’s picture

hostdog CreditAttribution: hostdog commented
FileSize
fatal_error_when-2820932-6.patch602 bytes

Steps to reproduce:

  1. Install and enable Domain Access modules
  2. Add an extra field at Basic Page Content Type
  3. Add Basic Page Content
  4. Delete the extra field from Basic Page Content type

I made a new patch to call getAccessValues with "\Drupal::service('domain_access.manager')->getAccessValues($entity);".
I don't know if this is the best approach.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

Calling a service class from inside the service class seems bad. I think the self:: approach should work.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

Using self:: seems to break all the tests.

Have you tried running any tests locally?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented

Never mind. I goofed the code.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Active » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ayalon’s picture

ayalon CreditAttribution: ayalon commented

This commit introduced a new message:

"Deprecated function: Non-static method Drupal\domain_access\DomainAccessManager::getAccessValues() should not be called statically in Drupal\domain_access\DomainAccessManager::getDefaultValue() (line 105 of modules/contrib/domain/domain_access/src/DomainAccessManager.php)."