[D7] 360° Image

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Muelheim-ruhr,

You don't have to define version in your .info file
Their is no need add dependency of .module file in .info file.

For reference please check below link.

https://www.drupal.org/docs/7/creating-custom-modules/writing-module-info-files-drupal-7x

Thanks,
Sahil

Automated Review

There were a number of issues that came up in the automated review. Please review this and make the recommended changes:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxmuelheim-ruhr2764835git

Manual Review

Individual user account
Yes: Follows

No duplication
No duplication, but there is a similar feature embedded in this module: https://www.drupal.org/project/views_slideshow_j360 - may be worth looking into.

Master Branch
Yes: Follows

Licensing
Should not have license.txt - Drupal adds that

3rd party assets/code
Yes, follows.

README.txt/README.md
Contains a README file, but could use more documentation--see: https://www.drupal.org/docs/develop/documenting-your-project/module-docu...

In particular, I think you should alert users through the Status Report page if the library is present and properly installed.

Code long/complex enough for review
Yes: Follows

Secure code
Yes: Meets the security requirements.

Coding style & Drupal API usage
See the comments in http://pareview.sh/pareview/httpsgitdrupalorgsandboxmuelheim-ruhr2764835git - when I opened the code, it seemed to be too far indented.

General Comments

I think this is a great idea for a module. I had a couple issues while using. Primarily, it gives me the option to apply an image style, but so far, it has only worked for me with original image. I had tried an image style that scaled the image to 400px wide, but that image style would not work with this module.

I also noticed a typo in line 63 of image_360degree.module:
'#title' => t('Schow Navbar'),
should be 'Show Navbar'

Hello,

I enabled the module and also included the photo_sphere_viewer in sites/all/libraries( the library includes the js files as mentioned in readme).But when creating a content and changing the manage display of image filed ,I am getting a fatal error while viewing the content.

Fatal error: Call to undefined function libraries_load() in /var/www/html/mysite/sites/all/modules/contrib/360_degree_image/image_360degree.module on line 278

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

@muelheim-ruhr,
Add hook_help() in your module file.

All issues are solved.

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.