Menu Active Trail is empty for built-in view pages

I see this issue as well. Do you have any idea if this is new or not? If it's relatively recent, we can bisect.

Verified that it's broken even in 8.0.6.

What seems to be happening here:

• When views generates the menu links, they are built without any route_parameters: https://github.com/drupal/drupal/blob/8.2.1/core/modules/views/src/Plugi...
• When looking at the current route, all variables (included defaulted ones) are used.

So these won't compare the same, and we end up with no active trail. Our options seem to be:

1. Views could just generate the menu links including the route_parameters. This would be a small fix, and would just fix this one case.
2. Drupal could enforce that menu links are always generated including route_parameters. This would fix the general case, but would require that every time we save a menu link, we load its route. Is that too heavy-weight?
3. Perhaps we could somehow manage this at lookup-time, instead of link generation time. But I don't see any way to allow menu links to be looked up both with or without defaulted route_parameters.

Here's a bit of code we used as a workaround, that basically does #1:

/**
 * Implements hook_menu_links_discovered_alter().
 *
 * This gives views menu links the right route_parameters setting, so that
 * they get the proper active trails.
 */
function scratchpad_menu_links_discovered_alter(&$links) {
  // Find menu links provided by views. For each link, find its route.
  $views_link_routes = [];
  foreach ($links as $key => $link) {
    if (!isset($link['provider']) || $link['provider'] != 'views') {
      continue;
    }
    $views_link_routes[$key] = $link['route_name'];
  }
  if (empty($views_link_routes)) {
    return;
  }

  // Load all the routes.
  /** @var \Drupal\Core\Routing\RouteProviderInterface $route_provider */
  $route_provider = \Drupal::service('router.route_provider');
  $routes = $route_provider->getRoutesByNames($views_link_routes);

  // Iterate over all the views links.
  foreach (array_keys($views_link_routes) as $key) {
    if ($route = $routes[$views_link_routes[$key]]) {
      // If we have a route, find the route variables.
      $link =& $links[$key];
      $variables = $route->compile()->getVariables();
      foreach ($variables as $v) {
        // If any variable is missing, add the default value.
        if (!isset($link['route_parameters'][$v])) {
          $link['route_parameters'][$v] = $route->getDefault($v);
        }
      }
    }
  }
}

Thoughts?

We should test on the 8.3.x or 8.4.x branch, I think.

#6Seems to be a totally reasonable fix, aka. provide the route parameters by default.

I experienced a problem with Views menu links having an empty trail in the following:

$parameters = $this->menuTree->getCurrentRouteMenuTreeParameters($menu_name);
$trail = $parameters->activeTrail; 

Implementing the function at #6 did the trick to fill it correctly. Thanks Vasi.

I am sorry that I am related new as Drupal site owner, for fixing #6, would you please offer a little bit more detailed explanation, such as which module and file it should be modified, really appreciate.

Actually, the error message I saw after upgrade to Drupal 8.5.3 is like this:

The website encountered an unexpected error. Please try again later.
TypeError: Argument 9 passed to Drupal\system\PathBasedBreadcrumbBuilder::__construct() must implement interface Drupal\Core\Path\PathMatcherInterface, instance of Drupal\Core\Menu\MenuActiveTrail given, called in /home/innovake/public_html/core/lib/Drupal/Component/DependencyInjection/Container.php on line 298 in Drupal\system\PathBasedBreadcrumbBuilder->__construct() (line 119 of core/modules/system/src/PathBasedBreadcrumbBuilder.php).
Drupal\system\PathBasedBreadcrumbBuilder->__construct(Object, Object, Object, Object, Object, Object, Object, Object, Object, Object) (Line: 298)
Drupal\Component\DependencyInjection\Container->createService(Array, 'current_page_crumb.breadcrumb') (Line: 171)
Drupal\Component\DependencyInjection\Container->get('current_page_crumb.breadcrumb', 1) (Line: 480)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 319)
Drupal\Component\DependencyInjection\Container->createService(Array, 'breadcrumb') (Line: 171)
Drupal\Component\DependencyInjection\Container->get('breadcrumb') (Line: 63)
Drupal\system\Plugin\Block\SystemBreadcrumbBlock::create(Object, Array, 'system_breadcrumb_block', Array) (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('system_breadcrumb_block', Array) (Line: 76)
Drupal\Component\Plugin\PluginManagerBase->createInstance('system_breadcrumb_block', Array) (Line: 62)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->initializePlugin('system_breadcrumb_block') (Line: 57)
Drupal\block\BlockPluginCollection->initializePlugin('system_breadcrumb_block') (Line: 80)
Drupal\Component\Plugin\LazyPluginCollection->get('system_breadcrumb_block') (Line: 45)
Drupal\block\BlockPluginCollection->get('system_breadcrumb_block') (Line: 83)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->setConfiguration(Array) (Line: 99)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->addInstanceId('system_breadcrumb_block', Array) (Line: 55)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->__construct(Object, 'system_breadcrumb_block', Array) (Line: 34)
Drupal\block\BlockPluginCollection->__construct(Object, 'system_breadcrumb_block', Array, 'breadcrumbs') (Line: 149)
Drupal\block\Entity\Block->getPluginCollection() (Line: 138)
Drupal\block\Entity\Block->getPlugin() (Line: 113)
Drupal\block\BlockAccessControlHandler->checkAccess(Object, 'view', Object) (Line: 105)
Drupal\Core\Entity\EntityAccessControlHandler->access(Object, 'view', Object, 1) (Line: 362)
Drupal\Core\Entity\Entity->access('view', NULL, 1) (Line: 56)
Drupal\block\BlockRepository->getVisibleBlocksPerRegion(Array) (Line: 137)
Drupal\block\Plugin\DisplayVariant\BlockPageVariant->build() (Line: 259)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 117)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object) (Line: 156)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 664)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

+1 to getting a core fix, rather than having to 'patch' using #6 in a custom module.

This is a duplicate of #2528166: Upcast named arguments/named parameters in views.