Problem/Motivation

There are a number of inconsistent declarations in js files. For example these are a few examples:

Attaches behavior for the Editor module.
Attaches behaviors for the Contextual module
Attaches the behaviors for the Color module.
Attaches the behavior for drupalAnnouce.
Javascript behaviors for the Book module.
Defines Javascript behaviors for the block_content module.

Proposed resolution

Maybe come up with some kind of "standardization", if that is possible.
I submit a patch with my proposal.

Remaining tasks

Postponed on an
Conform to Documenting behaviors.

User interface changes

None.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 inconsistent_comment_declarations-2820494-2.patch5.76 KBvagelis-prokopiou

Issue fork drupal-2820494

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Vagelis created an issue. See original summary.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Active » Needs review
FileSize
inconsistent_comment_declarations-2820494-2.patch5.76 KB

Here is the patch. My suggestion is:
Defines JavaScript behaviors for the...

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented

This is probably postponed on your other "JavaScript" patch.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented

Yes, sure. Do what you got to do.

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented

Relate this to the other issue and mark it postponed.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Needs review » Postponed
Related issues: +#684110: javscript should be JavaScript
vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Related issues: -#684110: javscript should be JavaScript +#2819245: "Javascript" should be "JavaScript"

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Category: Bug report » Task
Status: Postponed » Active
Issue tags: +Bug Smash Initiative, +JavaScript

This is no longer postponed.

The documentation is inconsistent but it is also correct, so I don't think this is a bug. Changing to task.

If this change is made how will this consistency be maintained? I am all for consistency but not sure about this one. I'll leave it to those who work with the JavaScript files, adding JavaScript tag.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
Issue tags: -JavaScript +JavaScript, +Coding standards
Parent issue: » #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

There is an existing standard for Documenting behaviors. The patch here is not following that so a new patch will be needed.

Adding tags and parent.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

shalini_jha made their first commit to this issue’s fork.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Status: Active » Needs work