The link type 'ajax_link' have to keep GET[destination] value no matter how many times you click on flag.

CommentFileSizeAuthor
#15 reroll-2820395-15.patch2.46 KBmsajko
#12 reroll-2820395-12.patch2.35 KBmartin107
#10 ajaxDestination-2820395-10.patch2.35 KBr.nabiullin
#10 interdiff-ajaxDestination-2820395-7-10.diff2.75 KBr.nabiullin
#7 ajaxDestination-2820395-7.patch745 bytesmsajko
#4 ajaxDestination-2820395-4.patch539 bytesmsajko
#2 ajaxDestination-2820395-2.patch669 bytesmsajko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

msajko created an issue. See original summary.

msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
Status: Active » Needs review
FileSize
ajaxDestination-2820395-2.patch669 bytes
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Needs work 
+++ b/src/ActionLink/ActionLinkTypeBase.php
@@ -91,6 +91,10 @@ abstract class ActionLinkTypeBase extends PluginBase implements ActionLinkTypePl
+    if($this->getPluginId() == 'ajax_link' && $destination = \Drupal::request()->query->get('destination')) {

This should go in AJAXactionLink rather than checking the plugin type!

msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
FileSize
ajaxDestination-2820395-4.patch539 bytes
msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
Status: Needs work » Reviewed & tested by the community
msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
Status: Reviewed & tested by the community » Needs review
FileSize
ajaxDestination-2820395-7.patch745 bytes
martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented 
+++ b/src/Plugin/ActionLink/AJAXactionLink.php
@@ -23,6 +23,16 @@ class AJAXactionLink extends Reload {
+    if($destination = \Drupal::request()->query->get('destination')) {
+      return $destination;
+    }

I'd also like a comment explaining what this is doing and why.

r.nabiullin’s picture

r.nabiullin CreditAttribution: r.nabiullin as a volunteer and at Skilld commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
interdiff-ajaxDestination-2820395-7-10.diff2.75 KB
ajaxDestination-2820395-10.patch2.35 KB

The last submitted patch, 10: interdiff-ajaxDestination-2820395-7-10.diff, failed testing. View results

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
FileSize
reroll-2820395-12.patch2.35 KB

A little reroll.

socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented 
+++ b/src/Plugin/ActionLink/AJAXactionLink.php
@@ -19,6 +22,58 @@ use Drupal\flag\FlagInterface;
+    if ($destination = $this->request->query->get('destination')) {

This is good, but like Joachim, I really would like a comment here explaining why we need this.

socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Needs review » Needs work
msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
FileSize
reroll-2820395-15.patch2.46 KB

If there is more then one flag on page we would like to have control on DOM element which is relate on e.q. click event and no matter how many times you call event.

msajko’s picture

msajko CreditAttribution: msajko at Websolutions Agency commented
Status: Needs work » Needs review

  • socketwench committed 2907910 on 8.x-4.x authored by msajko 
    Issue #2820395 by msajko, nabiyllin, martin107, socketwench, joachim:...
socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Needs review » Fixed

I did a bit more wordsmithing on the comment, but that's all.

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.