Replace usages of deprecated method db_change_field()

I am reparenting this to the meta of all things replacing db_

Patch looks good, but I do have some remarks:

1. +++ b/core/lib/Drupal/Core/Database/Schema.php
   @@ -518,9 +519,9 @@ public function fieldExists($table, $column) {
   +   * db_drop_{primary_key,unique_key,index}() before calling Schema::changeField().
   

   You cannot have more then 80 characters on a line with documentation.

2. +++ b/core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
   @@ -129,7 +129,7 @@ function testSchema() {
   +    Database::getConnection()->schema()->changeField('test_table', 'test_serial', 'test_serial', array('type' => 'serial', 'not null' => TRUE, 'description' => 'Changed column description.'), array('primary key' => array('test_serial')));
   
   @@ -728,7 +728,7 @@ protected function assertFieldChange($old_spec, $new_spec, $test_data = NULL) {
   +    Database::getConnection()->schema()->changeField($table_name, 'test_field', 'test_field', $new_spec);
   

   Please use \Drupal::database() instead of Database::getConnection().

3. +++ b/core/lib/Drupal/Core/Database/Schema.php
   @@ -535,7 +536,7 @@ public function fieldExists($table, $column) {
   +   * $injected_database->schema()->changeField('foo', 'bar', 'bar',
   

   Can we change this also to \Drupal::database()->schema()->changeField().

Changed

Fixed correction in #7 comment

This is probably not happening in 8.3 and note that we are trying to move doc changes to #2849745: Replace documentation recommending db_*() wrappers.

The patch is the same as the patch from comment #10, only without the documentation changes. Those will be done in #2849745: Replace documentation recommending db_*() wrappers.

All code changes are good.
All instances of the usage of db_drop_table() are replaced.
The patch looks good to me.
Because the patch was written by @darkdim, am I allowed to change the status to RTBC.

Thanks all. Those two usages are the self-tests of this function. So, this issue should maybe be closed as a duplicate of the docs one and whatever issue we file to look at the SchemaTest and other DB Kernel tests as a whole.

In #2848817-28: Replace all calls to db_table_exists, which is deprecated. I found one more test for refactoring

Actually docs issue is blocked on #2319859: [META] Deprecate contents of database.inc so here needs work to throw exception, working on it

Kind of that should be enough

Maybe it makes sense to create a separate test class for all deprecated functions testing?

Anyway this needs to be annotated with @group legacy to test expected exceptions but this makes all patches with such deprecated to require reroll if one commited like #2848952-33: Replace all calls to db_merge(), which is deprecated

As #2848812: Replace all calls to db_set_active, which is deprecated. better to annotate per method

Also fixed version

Fixed expectedDeprecation annotation

Patch no longer applies.

Postponed on #2991542: Introduce a DatabaseLegacyTest class for deprecation testing and #2991337: Document the recommended ways to obtain the database connection object

Here's a reroll + fixes to documentation.

We still miss a CR reference in the deprecation message. How about doing #2947946: Create change record for all deprecated db_* functions first and having a single Change Record with all the db* functions deprecated + directions on how to get the database connection being discussed in #2991337: Document the recommended ways to obtain the database connection object, instead of as many CRs as the deprecation issues?

Added reference to CR https://www.drupal.org/node/2993033

I think this is done now?

Looks it ready

Committed dcbb276 and pushed to 8.7.x. Thanks!