Problem/Motivation

The class property $plugin_id is unused, because we use $pluginId from the parent class

Proposed resolution

Remove the unused and confusing $plugin_id property.

CommentFileSizeAuthor
#2 filter-base-2818953-2.patch523 bytesklausi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Active » Needs review
FileSize
filter-base-2818953-2.patch523 bytes

Patch.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Title: Removed unused and confusing plugin_id property from FilterBase » Remove unused and confusing plugin_id property from FilterBase
googletorp’s picture

googletorp CreditAttribution: googletorp commented
Status: Needs review » Reviewed & tested by the community

Makes sense and looks good to me. Unless some one objects, should be RTBC imo.

  • catch committed 94a397a on 8.3.x 
    Issue #2818953 by klausi: Remove unused and confusing plugin_id property...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Yes this just looks like dead code.

Committed/pushed to 8.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.