Before the next release it seems good to do a sweep for Drupal code style.

There are a few issues to resolve...

http://pareview.sh/pareview/httpgitdrupalorgprojectemailconfirmgit-7x-1x

CommentFileSizeAuthor
#2 2818549-drupal-style.patch15.89 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles created an issue. See original summary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Active » Needs review
FileSize
2818549-drupal-style.patch15.89 KB

  • greggles committed 9f7ec01 on 7.x-1.x 
    Issue #2818549 by greggles: Update for Drupal code style

  • greggles committed c32f105 on 7.x-1.x 
    Issue #2818549 by greggles: Update for Drupal code style
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs review » Fixed

This is now done. Yay!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

I should have said: there are still some issues, but things are dramatically better. I may come back to this and would gladly accept patches to improve the situation further.

Status: Fixed » Needs work

The last submitted patch, 2: 2818549-drupal-style.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs work » Fixed

Thanks, testbot...this is "fixed" :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.