Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Providing a .make file alongside a module breaks distribution project because drush make discovers .make files recursively and does not handle gracefully the libraries declared at the module level.
Plus, versions of the libraries that you list in the provided .make file should be treated as example or suggestion. One can always decide to use older/news version as she sees fit.
Simplytest.me is able to read and handle .make.example files.
Similar issues on other contribs :
- Views Slideshow : #1330166: Disable makefile by default
- Proj4JS : #2420707: Rename .make file to .make.example
- Plupload integration : #2088143: [Needs docs] Add make file so dependencies are downloaded automatically
- Services : #1355952: Add drush make file to download spyc dependency
TL;DR : we should rename views_pdf.make to views_pdf.make.example
| Comment | File | Size | Author |
|---|---|---|---|
| views_pdf-rename_make_to_make_example.patch | 135 bytes | garphy |
Comments
Comment #3
vegansupreme CreditAttribution: vegansupreme commentedWorks for me. Committing this patch.