I came upon a weird behavior where translated content randomly disappeared on a live site. I tracked it down to this module. If the module entity_translation is present the translations belong to the same node. This module does not take this into account. E.g. revisions 1-9 are English and 10 is French. If the English content is edited once more, this module will just delete The French translation as it's the oldest revision which is deletable.
I marked this bug as major because it performs a destructive operation.
This is also relevant for a potential port to D8 because entity_translation is quite common and has been included in D8 core.

Comments

sammuell created an issue. See original summary.

hansfn’s picture

hansfn CreditAttribution: hansfn as a volunteer commented
Priority: Major » Critical

Marking this as critical since the module "cause loss/corruption of stored data" (according to poster).

mariancalinro’s picture

mariancalinro CreditAttribution: mariancalinro at Dream Production commented

I can confirm this, as we have the module enabled on a website, and it caused us loss of content. In the end we only enabled the functionality on the single content type we needed it, which was not translatable, and disabled it for the other ones, so at the moment this is not urgent enough for us to work on the issue and post a patch :(

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

@mariancalinro thanks for confirm the bug, at this moment I don't have time to work on this because I'm doing the Drupal 8 port, will be great if you can work on this later or help us in #2808383: Node Revision Delete Drupal 8 port

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Version: 7.x-2.6 » 7.x-3.x-dev
sja1’s picture

sja1 CreditAttribution: sja1 commented

Until this can be properly fixed, it would be a good idea to at least include a check as to whether a content type has entity translation enabled, and provide a warning or even prevent users from deleting revisions from such nodes.

I imagine that would be fairly quick and easy to implement would potentially save a number of people from grief.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

@sja1 is a good idea, can you help with this?

sja1’s picture

sja1 CreditAttribution: sja1 commented

@adriancid, I don't use this module. I came across it while looking at ways to reduce the size of my database, but in the end decided I didn't need it.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Status: Active » Closed (won't fix)