http://cgit.drupalcode.org/drupal/commit/?h=8.3.x&id=d561e62e0d8797bffaa... got commited, so we need to fix our tests to the new interface text.

CommentFileSizeAuthor
#14 fix_block_delete_tests-2817399-12.patch1.26 KBitsekhmistro
#11 fix_block_delete_tests-2817399-11.patch1.09 KBniko-
#3 fix_block_delete_tests-2817399-3.patch960 bytesborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

This is why the automated tests are currently failing: https://www.drupal.org/pift-ci-job/501391

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Active » Needs review
FileSize
fix_block_delete_tests-2817399-3.patch960 bytes

  • borisson_ committed 5c784c2 on 8.x-1.x 
    Issue #2817399 by borisson_: Fix block delete tests
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Fixed

Works, closed.

Status: Fixed » Needs work

The last submitted patch, 3: fix_block_delete_tests-2817399-3.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs work » Fixed

Status: Fixed » Needs work

The last submitted patch, 3: fix_block_delete_tests-2817399-3.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs work » Fixed

sssh testbot.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Fixed » Active
Issue tags: +Novice

Back to active, I discussed this being the reason that tests fail in irc with @mkalkbrenner.

mkalkbrenner: borisson_: can't we switch on the core version in this patch https://www.drupal.org/files/issues/fix_block_delete_tests-2817399-3.patch ?
borisson_: mkalkbrenner: in theory, yes.
mkalkbrenner: \Drupal::VERSION

So we need to do if (\Drupal::VERSION < 8.3) { // Code before the patch in #3. } else { // code changes with patch } or something similar. (that probably won't work, but that's the idea anyway.)

niko-’s picture

niko- CreditAttribution: niko- at Adyax commented
FileSize
fix_block_delete_tests-2817399-11.patch1.09 KB
niko-’s picture

niko- CreditAttribution: niko- at Adyax commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

This looks great, thanks! Tests pass on both 8.2 and 8.3.

itsekhmistro’s picture

itsekhmistro CreditAttribution: itsekhmistro at Adyax commented
FileSize
fix_block_delete_tests-2817399-12.patch1.26 KB

Minor fix added to patch in comment #11

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Changed the comment a little bit on commit. Thanks for helping out!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.