Add AMP video player integration [#2817233]

Problem/Motivation

AMP seems to be the hot new shit, so, well, let's provide a formatter which uses the built in AMP brightcove component.

Proposed resolution

This patch is build upon #2803173: Add a field formatter for the player

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#4	interdiff.txt	807 bytes	dawehner
#4	2817233-4.patch	3.39 KB	dawehner
#2	2817233-2.patch	3.36 KB	dawehner

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 October 2016 at 14:37

dawehner created an issue. See original summary.

File	Size
2817233-2.patch	3.36 KB

Comment #3

Boobaa

he/him

CreditAttribution: Boobaa at Pronovix for BrightCove commented 12 October 2016 at 14:50

Issue tags:

+D8Media, +Usability

Comment #4

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 30 January 2017 at 13:12

File	Size
2817233-4.patch	3.39 KB
interdiff.txt	807 bytes

This fixes the actual rendering of the video

Comment #5

Boobaa

he/him

CreditAttribution: Boobaa at Pronovix for BrightCove commented 24 February 2017 at 09:15

Status:

Needs review

» Needs work

+++ b/templates/brightcove-amp-video-player.html.twig
@@ -0,0 +1,29 @@
+{{ attach_library('amp/amp.brightcove') }}

How do you plan to depend on AMP.module if at all? If I understand this correctly, this line could cause some problems if amp.module's library is unavailable. Or does this patch have a counterpart in amp.module?

Comment #6

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 24 February 2017 at 16:29

+++ b/src/Plugin/Field/FieldFormatter/BrightcoveAmpVideoPlayerFormatter.php
@@ -0,0 +1,49 @@
+  public static function isApplicable(FieldDefinitionInterface $field_definition) {
+    return parent::isApplicable($field_definition) && \Drupal::moduleHandler()->moduleExists('amp');
+  }

Note: You could just configure this formatter, if the module exists.