Process plugin link_uri shouldn't be in d6 namespace

Adding patch as suggested.

New patch added as suggested.Kindly ignore the previous patch.

Fixing the patch in #6. Actually, this was a completely new patch as it was an easy task.

This was done in a live demo on Drupal contributions webinar.

Moving test as well.

Random failure

Should we add a temporary bc layer here in case someone is subclassing the plugin? Otherwise this can only go into 8.2.x

I understand your concerns, but I think it's highly unlikely that someone might be doing that.

I think @catch raises a good point. It's highly unlikely anyone is subclassing it, but this is Drupal, everything is overridable, and we can't be certain. This is a good task for a novice -- let's keep LinkUri outside the d6 namespace, but put a subclass of it in the d6 namespace and mark it deprecated.

The deprecation text should be something like this:

@deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0. Use \Drupal\menu_link_content\Plugin\migrate\process\LinkUri instead.

Hi everyone, I made a patch where added the message for Drupal\menu_link_content\Plugin\migrate\process\d6\LinkUri like @deprecated.

I have fixed the previous patch.

Except for these two things, looks good to me. Thank you, @Adita!

1. +++ b/core/modules/menu_link_content/src/Plugin/migrate/process/d6/LinkUri.php
   @@ -9,76 +9,16 @@
   +use \Drupal\menu_link_content\Plugin\migrate\process\LinkUri as OtherLinkUri;
   

   "OtherLinkUri" got a smile from me, but it's kinda vague-sounding; can we import it as BaseLinkUri or DeprecatedLinkUri?

2. +++ b/core/modules/menu_link_content/src/Plugin/migrate/process/d6/LinkUri.php
   @@ -9,76 +9,16 @@
     * @MigrateProcessPlugin(
     *   id = "link_uri"
     * )
   

   This should be removed.

@phenaproxima thanks for your commentaries I got better

Can someone explain how this is related to #2669978: Migrate D7 Menu Links and #2822881: Improve Entity URI checking in menu link migration?

The first one introduced a separate uri plugin for the D7 menu link migration and the second one was opened to consolidate that with the D6 version or at least bring it into feature parity.

I don't really understand that in light of this issue, to be honest.

re #21: this is a quick fix to move the class into a non-drupal versioned namespace. When #2669978: Migrate D7 Menu Links went in, it didn't fix the namespace. We'll improve things even more in #2822881: Improve Entity URI checking in menu link migration, but let's get the simple namespace issue fixed first.

#19 is fixed.

Ahh, this is just a rename, I understand. In these cases it's nice to create patches with -C -M, so that is more clear. Thanks anyway for the explanation!

Re-rolled patch. No changes so I'm leaving this at RTBC.
(8.2.x) $ git diff --cached -M >process_plugin_link_uri-2816857-24.patch

Thanks for maintaining BC - the patch looks good - just one small thing:

+++ b/core/modules/menu_link_content/src/Plugin/migrate/process/d6/LinkUri.php
@@ -9,76 +9,13 @@
+use \Drupal\menu_link_content\Plugin\migrate\process\LinkUri as DeprecatedLinkUri;

This looks weird - the name 'DeprecatedLinkUri' is being used for the thing that is not deprecated :) - How about just calling it RealLinkUri?

Changed DeprecatedLinkUri to RealLinkUri.

And ready again.

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

Fixed unused use statements on commit.