Offer View choice as select list [#2816567]

First of all, thanks for all the hard work, New Zeal!
I'm opening a series of feature requests to track progress on this module.

The current widget assumes that users know the name of the View. In certain set-ups with non-technical users or restricted permissions, this can be hard to use, since users would have to "guess" the name of the View they're trying to reference. An additional widget which presents the options as a Select list would solve this issue.

Comment	File	Size	Author
#4	offer_view_choice_as-2816567-4.patch	6.76 KB	joekers
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 October 2016 at 13:57

Algeron created an issue. See original summary.

Comment #2

NewZeal CreditAttribution: NewZeal as a volunteer commented 21 October 2016 at 19:40

Suggestion noted. There are a number of improvements that can be done to the selection process. Thanks.

Comment #3

joekers

English

CreditAttribution: joekers as a volunteer and at Zoocha commented 22 October 2016 at 08:58

Assigned:

Unassigned

» joekers

I could do with this on a project I'm working on so I'm going to give it a try.

Comment #4

joekers

English

CreditAttribution: joekers as a volunteer and at Zoocha commented 26 November 2016 at 17:12

Status:

Active

» Needs review

File	Size
offer_view_choice_as-2816567-4.patch	6.76 KB

I haven't had any chance to take a look at this until today.

Working patch attached but there's one thing I'm not sure of: validateElement removing this and the line that adds it (element_validate) gives this error:
InvalidArgumentException: Value is not a valid entity. in Drupal\Core\Entity\Plugin\DataType\EntityReference->setValue()

Any feedback would be much appreciated :)

Comment #5

NewZeal CreditAttribution: NewZeal as a volunteer commented 27 November 2016 at 18:20

I've pushed this with the alpha 6 release. Because this is still alpha and the plugin is a separate script, then it works to use this method for testing by the community. I also invite you to be a maintainer of the module. Let me know if you want to accept.