Incorrect sitemap content urls with languages settings set to domains [#2815631]

Looks like if we have languages enabled by setting different domains (fx, solar.com, solar.de, solar.dk etc..) for different languages, then accessing generated sitemap fx., http://solar.com/sitemap.xml
we see such links:
http://default/http://solar.com/node/100
http://default/http://solar.com/node/101
http://default/http://solar.com/node/102

where "http://default" is the "Default base URL".

We would like to have this field not used if domains are set in language settings and also we would like to have different sitemaps for each language, so that:

http://solar.com/sitemap.xml - provides links to EN language content with domain http://solar.com
http://solar.de/sitemap.xml - provides links to DE language content with domain http://solar.de
etc..

Comment	File	Size	Author
#8	xmlsitemap-incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-8.patch	1.13 KB	hswong3i
#8	8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks
#4	incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-4.patch	1.16 KB	SylvainM
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail
#3	incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-3.patch	1.27 KB	evaldask
#3	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 2 fail
#2	incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-2.patch	1.27 KB	evaldask
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 October 2016 at 08:46

evaldask created an issue. See original summary.

Comment #2

evaldask CreditAttribution: evaldask at Adapt for Novasol commented 10 October 2016 at 13:07

Status:

Active

» Needs review

File	Size
incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-2.patch	1.27 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 2 fail

I've looked at the latest dev version - content urls were already fixed, but there's still an issue to get the sitemap.xml loaded with different language.

Trying to access DK version http://solar.dk/sitemap.xml Firefox shows:
Error loading stylesheet: An unknown error has occurred (805303f4)
http://solar.com/sitemap.xsl
Chrome displays white window.

Sitemaps were generated with admin in http://solar.com/admin/config/search/xmlsitemap

Sitemap is not loaded because http://solar.dk/sitemap.xml loads xml with this line
<?xml-stylesheet type="text/xsl" href="http://solar.com/sitemap.xsl"?>

it should be
<?xml-stylesheet type="text/xsl" href="http://solar.dk/sitemap.xsl"?>

I've added patch for that.

Comment #3

evaldask CreditAttribution: evaldask at Adapt for Novasol commented 10 October 2016 at 13:09

File	Size
incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-3.patch	1.27 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 2 fail

1 file was hidden/shown/deleted

File	Size
incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-2.patch	1.27 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 2 fail

Comment #4

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented 13 October 2016 at 12:46

File	Size
incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-4.patch	1.16 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail

1 file was hidden/shown/deleted

File	Size
incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-3.patch	1.27 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 2 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 2 fail

Attached patch fixes paths

Comment #5

poukram CreditAttribution: poukram commented 13 October 2016 at 12:49

Status:

Needs review

» Reviewed & tested by the community

thanks guys, the last patch with good paths works fine!

Comment #6

juampynr CreditAttribution: juampynr at Lullabot commented 13 October 2016 at 16:25

+++ b/src/XmlSitemapWriter.php
@@ -121,7 +121,19 @@ public function startDocument($version = '1.0', $encoding = 'UTF-8', $standalone
+        $xls_url = Url::fromRoute('xmlsitemap.sitemap_xsl');

Can we move this up so we call fromRoute just once?

Also, can you provide steps to reproduce this issue? With them we may be able to write a test that proves the bug.

Comment #7

juampynr CreditAttribution: juampynr at Lullabot commented 13 October 2016 at 16:25

Status:

Reviewed & tested by the community

» Needs work

Comment #8

hswong3i CreditAttribution: hswong3i commented 12 September 2017 at 03:57

Status:

Needs work

» Needs review

File	Size
xmlsitemap-incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-8.patch	1.13 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

1 file was hidden/shown/deleted

File	Size
incorrect-sitemap-content-urls-with-languages-settings-set-to-domains-2815631-4.patch	1.16 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail

Update #4 patch via latest 8.x-1.x-dev

Comment #9

hswong3i CreditAttribution: hswong3i commented 20 September 2018 at 05:05

Status:

Needs review

» Reviewed & tested by the community

I had been using this patch for more than a year and error gone as expected, should be good enough for RTBC?

Comment #10

alex_optim

🇺🇦 Rivne

CreditAttribution: alex_optim at GOLEMS GABB for GOLEMS GABB commented 20 September 2018 at 21:57

Comment #11

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for GOLEMS GABB, Drupal Ukraine Community commented 20 September 2018 at 22:00

Comment #12

20 September 2018 at 22:01

pifagor committed 51f9ed4 on 8.x-1.x authored by hswong3i

Issue #2815631 by evaldask, hswong3i, SylvainM, juampynr, alex_optim,...

Comment #13

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for GOLEMS GABB, Drupal Ukraine Community commented 20 September 2018 at 22:01

Status:

Reviewed & tested by the community

» Fixed

Comment #14

hkirsman CreditAttribution: hkirsman commented 22 September 2018 at 20:02

I have the latest dev version but the output of sitemap.xml is still:

Sitemap file: http://local.developer.tekla.com/sitemap.xml
Number of sitemaps in this index: 2

Sitemap URL	Last modification date
http://default//sitemap.xml?page=2	2018-09-22T19:57Z
http://default//sitemap.xml?page=1	2018-09-22T19:57Z
Generated by the Drupal XML sitemap module.

Is this another bug?