Just a bit of clean-up, patch coming.

CommentFileSizeAuthor
#3 interdiff-2813733-2-3.txt4.15 KBmartin107
#3 2813733-3.flag_.rel-handler-cleanup.patch4.61 KBmartin107
#2 2813733-2.flag_.rel-handler-cleanup.patch942 bytesjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
2813733-2.flag_.rel-handler-cleanup.patch942 bytes

$default_value is only used once, so no need to set it.

And when we iterate over the result of getFlags(), there's no need to check if the values are empty. getFlags() returns flags, they're flags!

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
FileSize
2813733-3.flag_.rel-handler-cleanup.patch4.61 KB
interdiff-2813733-2-3.txt4.15 KB

@joachim

if this is a general purpose cleanup in addition I would like to :-

1) Inject the flag and kill switch service directly.

2) Fix a few mis-steaks identified by phpcs

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Thanks!

Committed, with one small tweak:

> * Constructs a PluginBase object.

  • joachim committed 99e8786 on 8.x-4.x authored by martin107 
    Issue #2813733 by martin107, joachim: Fixed various niggles in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.