There seems to be some simple logic errors in the code.

There is a variable search404_skip_auto_search which when you set to TRUE, you would expect would stop the automatic searching upon entering a 404. But you would be wrong. If you set search404_do_custom_search to TRUE, then an actual search is performed. This seems like a fairly severe bug. Having a search automatically execute on a highly trafficed site will bring it down.

What I expected to happen

When you set search404_skip_auto_search to TRUE, then this would apply globally.

CommentFileSizeAuthor
#4 stop_auto_searching_for_reals-2813549-4.patch669 bytesakhilavnair
#2 2813549-stop-auto-searching-for-reals.patch669 byteswiifm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wiifm created an issue. See original summary.

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm as a volunteer and at Acquia commented
Status: Active » Needs review
FileSize
2813549-stop-auto-searching-for-reals.patch669 bytes
wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm as a volunteer and at Acquia commented
Issue summary: View changes
akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
CreditAttribution: akhilavnair at Zyxware Technologies commented
FileSize
stop_auto_searching_for_reals-2813549-4.patch669 bytes

I think your point is right and your patch needs to be reroll. So If you don't mind, I have rerolled and created a new patch.

deepa_lissa’s picture

deepa_lissa CreditAttribution: deepa_lissa at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community

Patch works fine. Thanks.

zyxware’s picture

zyxware CreditAttribution: zyxware at Zyxware Technologies commented
Status: Reviewed & tested by the community » Fixed

Applied the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.