Problem/Motivation

There is no schema for the defined entity browser widgets.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-2-5.txt734 byteschr.fritsch
#5 add_missing_eb_widget-2813143-5.patch1.38 KBchr.fritsch
#2 add_missing_eb_widget-2813143-2.patch1.35 KBchr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review
FileSize
add_missing_eb_widget-2813143-2.patch1.35 KB

Here is a patch, that adds a the schema.yml

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Issue tags: +D8Media
Primsi’s picture

Primsi CreditAttribution: Primsi for Examiner.com commented
Status: Needs review » Needs work

Thanks for the patch. Just one small thing, otherwise looks ok.

  1. +++ b/modules/eb_widget/config/schema/dropzonejs_eb_widget.schema.yml
@@ -0,0 +1,42 @@
+  label: 'View widget configuration'

    Probably leftover from the used example. 

  2. +++ b/modules/eb_widget/config/schema/dropzonejs_eb_widget.schema.yml
@@ -0,0 +1,42 @@
+  label: 'View widget configuration'

    Same as above.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
FileSize
add_missing_eb_widget-2813143-5.patch1.38 KB
interdiff-2-5.txt734 bytes

Fixed the label properties

Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH commented

Looks fine. Thanks :)

  • Primsi committed e68db0c on 8.x-1.x authored by chr.fritsch 
    Issue #2813143 by chr.fritsch, Primsi: Add missing EB widget schema
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.