Problem/Motivation

If you have mailto:user@example.com?subject=hello that will be accepted as valid email address, but mailto:user@example.com?subject=Hello is considered invalid.

Proposed resolution

Allow upper case characters in the query and anchor regex patterns, they are perfectly fine.

CommentFileSizeAuthor
#7 link-mailto-2813057-7.patch721 bytesklausi
#5 link-mailto-2813057-5.patch721 bytesJohn Cook
#2 link-mailto-2813057-2.patch757 bytesklausi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Active » Needs review
FileSize
link-mailto-2813057-2.patch757 bytes

Patch.

Status: Needs review » Needs work

The last submitted patch, 2: link-mailto-2813057-2.patch, failed testing.

JKingsnorth’s picture

JKingsnorth CreditAttribution: JKingsnorth commented
Status: Needs work » Needs review

Confirmed the issue and the fix works well, thanks! One more review?

John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
FileSize
link-mailto-2813057-5.patch721 bytes

I've re-rolled klausi's patch from #2.

Status: Needs review » Needs work

The last submitted patch, 5: link-mailto-2813057-5.patch, failed testing. View results

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs work » Needs review
FileSize
link-mailto-2813057-7.patch721 bytes

@John: you forgot to update the variable names that have changed in the meantime.

Patch rerolled, let's see if the tests pass now.

  • pifagor committed 77386a6 on 7.x-1.x authored by klausi 
    Issue #2813057 by klausi, pifagor, John Cook: mailto: link with subject...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Needs review » Fixed
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented

The patch was only missing some automated test cases, but that can be added in a follow-up issue.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented

Hello @klausi
If you add them, I will be grateful

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.